Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import on keywords-as-identifiers recipe #269

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

leonardtudorache
Copy link
Contributor

langium has no exported member AbstractSemanticTokenProvider or SemanticTokenAcceptor. These should be imported from langium/lsp.

Copy link

github-actions bot commented Nov 20, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-11-20 22:39 UTC

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leonardtudorache, thank you for the contribution!

Due to legal reasons, contributors to Langium (or rather all Eclipse Foundation projects) must sign the Eclipse Contribution Agreement with the same email that was used to create the commit before we're able to merge the changes (no matter how small).

Can you do that? Otherwise I will just create a PR myself with the necessary changes and close this one.

@leonardtudorache
Copy link
Contributor Author

Hi @msujew, I have signed the agreement.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! We wrote this guide before we split the LSP stuff from the main import in v3 which was the source of the issue.

@msujew msujew merged commit 39999f5 into eclipse-langium:main Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants