Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong type in example #259

Closed
wants to merge 1 commit into from
Closed

Fix wrong type in example #259

wants to merge 1 commit into from

Conversation

didrikmunther
Copy link

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-11-01 17:09 UTC

msujew
msujew previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks!

@msujew msujew dismissed their stale review October 30, 2024 10:41

ECA wasn't successful

msujew
msujew reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@msujew msujew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that the ECA wasn't signed yet (most likely because the commit was actually created by GitHub and not manually via the git client). Due to legal reasons, contributors to Langium (or rather all Eclipse Foundation projects) must sign the Eclipse Contribution Agreement before we're able to merge the changes (no matter how small).

@didrikmunther Can you do that? Otherwise I will just create a PR myself with the necessary changes and close this one.

@didrikmunther
Copy link
Author

I just noticed that the ECA wasn't signed yet (most likely because the commit was actually created by GitHub and not manually via the git client). Due to legal reasons, contributors to Langium (or rather all Eclipse Foundation projects) must sign the Eclipse Contribution Agreement before we're able to merge the changes (no matter how small).

@didrikmunther Can you do that? Otherwise I will just create a PR myself with the necessary changes and close this one.

I'd rather not do that for a change this small. Feel free to create a PR yourself with this change!

@msujew msujew mentioned this pull request Oct 30, 2024
Merged
@msujew
Copy link
Member

msujew commented Oct 30, 2024

@didrikmunther Thank you, that's understandable. I've created #260, and this PR will be automatically closed once the other one is merged.

@msujew msujew closed this in #260 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@didrikmunther @msujew