#256 Fix rendering issue in "Langium's workflow" flowchart #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own: list" Updated the steps in the workflow flowchart to use non-breaking spaces to prevent recognition of markdown numbered lists which is not supported by mermaid.
Replaced `\n` with `<br/>` in the mermaid flowchart diagram to ensure proper line breaks in the rendered HTML.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #256.
The rendering issues might be caused by markdown numbered list recognition in flow chart nodes (e.g.
1. Install Yeoman).Escaping the
.as proposed here, i.e.1\. Install Yeoman, did not work for me (Safari 17.6):As a workaround this PR adds a non-breaking space to prevent numbered lists, e.g.
1. Install Yeoman.This seems to fix the rendering issue (tested on Safari 17.6):
Additionally, the flow chart node
for each additional\ngrammar changeseems to not render the line break as intended.Replacing
\nwith<br/>results in a proper line break (Safari 17.6):