Recipe: File-based symbol import/export #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
msujew
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Great, I didn't fully review it yet, will get to it later this week. A small request: Can you attach the whole code (similar to here) to the end of the recipe? That would make it easier for people to just copy it in case they made a mistake at a certain part.
Done :) |
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
Possible things to add:
|
Lotes
changed the title
msujew
reviewed
Jun 27, 2024
Co-authored-by: Mark Sujew <[email protected]>
Co-authored-by: Mark Sujew <[email protected]>
Co-authored-by: Mark Sujew <[email protected]>
Co-authored-by: Mark Sujew <[email protected]>
Co-authored-by: Mark Sujew <[email protected]>
Co-authored-by: Mark Sujew <[email protected]>
Co-authored-by: Mark Sujew <[email protected]>
Co-authored-by: Mark Sujew <[email protected]>
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a recipe based on the Hello World example about file-based imports. They are added shortly to the scoping overview page.
I used the "Simpsons" for exporting persons, feel free to suggest some cooler persons.
One might add hints for missing validations or other LSP services, that make this feature more attractive.
Closes #234