Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links checker and add aliases #237

Merged
merged 9 commits into from
Jun 4, 2024
Merged

Add links checker and add aliases #237

merged 9 commits into from
Jun 4, 2024

Conversation

Lotes
Copy link
Contributor

@Lotes Lotes commented May 27, 2024 •
edited
Loading

This PR adds a checker for all links inside of Markdown files under /hugo/content.

I added aliases to the pages so that old links outside the webpage still work.

My checker has two levels:

  • MISSING LINKS are links that point to no valid internal location
  • ALIAS LINKs are links that point to an alias of an internal document, but not to its direct link

Both levels will lead to a failed build/check.

Comments/suggestions/improvements are welcome.

@Lotes Lotes temporarily deployed to pull-request-preview May 27, 2024 09:01 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2024 •
edited
Loading

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-06-04 15:24 UTC

@Lotes Lotes mentioned this pull request May 27, 2024
Merged
@Lotes Lotes temporarily deployed to pull-request-preview May 29, 2024 13:07 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview May 29, 2024 13:14 — with GitHub Actions Inactive
@Lotes Lotes force-pushed the lotes/links-checker branch from 1688f2b to 934d7c0 Compare May 29, 2024 13:29
@Lotes Lotes temporarily deployed to pull-request-preview May 29, 2024 13:31 — with GitHub Actions Inactive
@Lotes
Copy link
Contributor Author

Lotes commented May 29, 2024 •
edited
Loading

The last thing that needs to be done is a check of the GH action.

Here is an example build that fails.

@Lotes Lotes marked this pull request as ready for review May 29, 2024 13:33
msujew
msujew reviewed May 29, 2024
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.

scripts/check-links.ts Outdated Show resolved Hide resolved
scripts/check-links.ts Outdated Show resolved Hide resolved
.github/workflows/links.yml Outdated Show resolved Hide resolved
@Lotes Lotes temporarily deployed to pull-request-preview May 29, 2024 13:40 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview May 29, 2024 13:44 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview May 29, 2024 13:52 — with GitHub Actions Inactive
msujew
msujew approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@msujew msujew merged commit ad3bbc2 into main Jun 4, 2024
5 checks passed
@msujew msujew deleted the lotes/links-checker branch June 4, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lotes @msujew