Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New recipe: Case-insensitivity #233

Merged
merged 4 commits into from
May 23, 2024
Merged

New recipe: Case-insensitivity #233

merged 4 commits into from
May 23, 2024

Conversation

Lotes
Copy link
Contributor

@Lotes Lotes commented May 22, 2024

Explains how to implement case-insensitivity in Langium.

Adds an extra folder: to be filled with other "Lexis topics". I think we can split #219 into 3-4 independent recipes.

@Lotes Lotes temporarily deployed to pull-request-preview May 22, 2024 07:17 — with GitHub Actions Inactive
Copy link

github-actions bot commented May 22, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-05-23 12:34 UTC

@Lotes Lotes force-pushed the lotes/more-guides branch from 09e4c94 to bd40bc1 Compare May 22, 2024 07:25
@Lotes Lotes temporarily deployed to pull-request-preview May 22, 2024 07:27 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview May 23, 2024 12:27 — with GitHub Actions Inactive
@Lotes
Copy link
Contributor Author

Lotes commented May 23, 2024

@msujew thanks for the precise review, I copied over your changes. I know there is a "submit suggestions" button, but I like to have a bit of control over the content :D.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the comment above, this looks good to me 👍

@Lotes Lotes merged commit 9bb0160 into main May 23, 2024
4 checks passed
@Lotes Lotes deleted the lotes/more-guides branch May 23, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants