Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update showcases and playground to Langium 3.0.0 #220

Merged
merged 14 commits into from
Apr 26, 2024
Merged

Update showcases and playground to Langium 3.0.0 #220

merged 14 commits into from
Apr 26, 2024

Conversation

Lotes
Copy link
Contributor

@Lotes Lotes commented Mar 20, 2024

  • it was required to update the dependencies first (Langium/SQL + Langium/Minilogo)
  • I moved from Monarch to TextMate for the Playground syntax highlighting to have a unified approach
  • migrated imports to access only Langium exports and using the .js suffix
  • cleanup not required files

@Lotes Lotes temporarily deployed to pull-request-preview March 20, 2024 09:41 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-04-26 07:28 UTC

@Lotes Lotes temporarily deployed to pull-request-preview March 20, 2024 09:47 — with GitHub Actions Inactive
kaisalmen
kaisalmen reviewed Mar 21, 2024
View reviewed changes
Copy link
Contributor

@kaisalmen kaisalmen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I left a couple of comments.

hugo/content/playground/common.ts Show resolved Hide resolved
hugo/content/playground/preprocess.ts Outdated Show resolved Hide resolved
hugo/content/playground/textmate-generator.ts Outdated Show resolved Hide resolved
hugo/package.json Outdated Show resolved Hide resolved
hugo/tsconfig.json Show resolved Hide resolved
core/package.json Show resolved Hide resolved
@kaisalmen kaisalmen mentioned this pull request Mar 26, 2024
Draft
@Lotes Lotes temporarily deployed to pull-request-preview April 2, 2024 07:00 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview April 2, 2024 07:07 — with GitHub Actions Inactive
@Lotes Lotes mentioned this pull request Apr 2, 2024
Merged
@montymxb montymxb self-requested a review April 2, 2024 11:59
montymxb
montymxb reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but just need to wait for the textmate grammar export to be available, which we can then consume.

@Lotes Lotes temporarily deployed to pull-request-preview April 23, 2024 07:43 — with GitHub Actions Inactive
@Lotes Lotes mentioned this pull request Apr 23, 2024
Merged
@Lotes
Copy link
Contributor Author

Lotes commented Apr 23, 2024

@montymxb PR is ready to be approved. Last insertion adds langium-cli/textmate as source for the syntax highlighter.

msujew
msujew approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you 👍

@kaisalmen
Copy link
Contributor

@Lotes or @msujew can we merge this. I would like to get #222 ready for review (it is just a rebase now).

@Lotes Lotes merged commit 7e440a0 into main Apr 26, 2024
4 checks passed
@Lotes Lotes deleted the lotes/bump-to-langium-3.0.0 branch April 26, 2024 07:28
@msujew msujew mentioned this pull request May 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen left review comments

@montymxb montymxb montymxb left review comments

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lotes @kaisalmen @msujew @montymxb