Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a guide for multiple languages support #191

Merged
merged 8 commits into from
Dec 13, 2023

Conversation

Lotes
Copy link
Contributor

@Lotes Lotes commented Sep 28, 2023

The guide uses Hello world! as entry grammar and splits it into 3 interconnected grammars.

Copy link
Contributor

@gfontorbe gfontorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lotes ! Very easy guide to follow.

Just some minor comments about the text

hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
@Lotes
Copy link
Contributor Author

Lotes commented Sep 28, 2023

Thanks @gfontorbe ! What do you think about providing an example repo? I can also drop my local repo with multi-language support, if the guide is so easy to follow.

@Lotes
Copy link
Contributor Author

Lotes commented Nov 16, 2023

We already have an example in the main repo for multi-language support. I can refer to that one.

Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just one remark.

hugo/content/guides/multiple-languages.md Outdated Show resolved Hide resolved
@Lotes Lotes merged commit 8a3d0be into eclipse-langium:main Dec 13, 2023
1 of 2 checks passed
@Lotes Lotes deleted the lotes/multiple-languages branch December 13, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants