Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Windows IT #141

Merged
merged 1 commit into from
Apr 3, 2020
Merged

test: Windows IT #141

merged 1 commit into from
Apr 3, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Apr 3, 2020

Closes: #131

There's no easy solution to add complete e2e tests for Windows Server 2019 (ephemeral k8s cluster).

Hyper-V is not enabled in GH Actions and enabling requires a VM restart which makes the GH Runner loose the connection to the VM.

Minikube with Virtualbox is not an option either, as it requires vt-x to be enabled (which isn't).

Trying to enable Linux container support doesn't work well and relies on experimental features (lcow project has been archived too), so running alternatives to Minikube (k3s, MicroK8s, etc.) is also impossible.

Current PR will create a Windows Container compatible Docker image and test resource generation.
Tested Eclipse JKube Features:

  • build (k8s)
  • push (k8s)
  • resource (k8s & oc)
  • helm (k8s & oc)

Blocked by: eclipse-jkube/jkube-integration-tests#31

@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #141 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
+ Coverage     25.54%   25.57%   +0.03%     
- Complexity     1544     1547       +3     
============================================
  Files           350      350              
  Lines         19337    19337              
  Branches       2907     2907              
============================================
+ Hits           4939     4945       +6     
+ Misses        13828    13823       -5     
+ Partials        570      569       -1
Impacted Files Coverage Δ Complexity Δ
...kit/build/core/assembly/DockerAssemblyManager.java 44.71% <0%> (ø) 28% <0%> (ø) ⬇️
...java/org/eclipse/jkube/kit/common/util/IoUtil.java 80.7% <0%> (+10.52%) 12% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5158d5...340bdce. Read the comment docs.

@manusa manusa force-pushed the test/windows-it branch 4 times, most recently from ea43921 to 1350d9e Compare April 3, 2020 09:55
Signed-off-by: Marc Nuri <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@manusa manusa marked this pull request as ready for review April 3, 2020 10:23
@manusa manusa merged commit f4cf32f into eclipse-jkube:master Apr 3, 2020
@manusa manusa deleted the test/windows-it branch April 3, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: jar artifact generated in wrong directory
2 participants