Fix UI on Mac OS preview viewer #844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did default method in interface to support backward compatibility, but for API tools it's still API breakage :( |
|
I'll propose this when LTK become part of plaform. Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes UI issues on Mac OS, originally reported on platform side: eclipse-platform/eclipse.platform.ui#1173
To fix this, I introduced new method in IChangePreviewViewer, that allow to inject ICompareContainer
PreviewWizardPage, contribute own ICompareContainer to it's viewers
How to test
Run some refactoring changes on JDT project and switch between texts. More details in bug
Author checklist