Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify string concat to text block cleanup to handle empty strings #1717

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jjohnstn
Copy link
Contributor

What it does

See commit message and issue.

How to test

See issue and test modifications.

Author checklist

- add logic to StringConcatToTextBlockFixCore to handle the case where
  empty strings are appended
- modify tests in CleanUpTest15 to add some empty strings to existing
  tests
- for eclipse-jdt#1703
@jjohnstn jjohnstn self-assigned this Oct 15, 2024
@jjohnstn jjohnstn added the bug Something isn't working label Oct 15, 2024
@jjohnstn jjohnstn added this to the 4.34 M2 milestone Oct 15, 2024
@jjohnstn jjohnstn merged commit c2ceaa2 into eclipse-jdt:master Oct 15, 2024
10 checks passed
@jjohnstn jjohnstn deleted the textblockempty branch October 15, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant