changing the visability Constants in the CallHierarchy #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukzi
reviewed
Oct 9, 2024
| @@ -60,25 +56,25 @@ public static CallHierarchy getDefault() { | |||
| public boolean isSearchUsingImplementorsEnabled() { | |||
| IPreferenceStore settings = JavaPlugin.getDefault().getPreferenceStore(); | |||
|
|
|||
| return settings.getBoolean(PREF_USE_IMPLEMENTORS); | |||
| return settings.getBoolean(CallHierarchyCore.PREF_USE_IMPLEMENTORS); | |||
There was a problem hiding this comment.
static import CallHierarchyCore.* instead?
There was a problem hiding this comment.
Better all 4 static imports since org.eclipse.jdt.ui.staticondemandthreshold=99 (in org.eclipse.jdt.core.manipulation/.settings/org.eclipse.jdt.ui.prefs)
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_FILTERS_LIST;
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_FILTER_TESTCODE;
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_USE_FILTERS;
import static org.eclipse.jdt.internal.corext.callhierarchy.CallHierarchyCore.PREF_USE_IMPLEMENTORS;There was a problem hiding this comment.
i have imported all 6 constants to callHierarchy.
fedejeanne
reviewed
Oct 9, 2024
jannisCode
force-pushed
the
visability_fix_cH
branch
from
755d1b5
to
46bb287
Compare
|
resolve the merge conflict, please |
jannisCode
force-pushed
the
visability_fix_cH
branch
from
46bb287
to
2f5bbd3
Compare
jukzi
approved these changes
Oct 9, 2024
jannisCode
force-pushed
the
visability_fix_cH
branch
from
2f5bbd3
to
928979d
Compare
fedejeanne
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
It does not have any effect on the functionality, but it addresses and completes the suggestion from @jukzi which he made here: (#1687)
Because the constants of which the visability is changed here are not part of PR #1687 , this PR is aimed at completing the suggestion made there.
Author checklist