Fixdeprecations #1686
Merged
Fixdeprecations #1686
+30
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstenartur
force-pushed
the
fixdeprecations
branch
from
bc7fea8
to
9e3d2a7
Compare
|
Hi @jjohnstn , when you find the time could you have a look? While we reduced the amount of warnings with the last patch by half we are still one of the projects with the highest amount of deprecations. If you are unsure about one or another change feel free to leave it out this time. |
|
Hi @carstenartur Will look at it today. |
jjohnstn
requested changes
Oct 4, 2024
...e.manipulation/common/org/eclipse/jdt/internal/core/manipulation/JavaManipulationPlugin.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaPlugin.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/JavaPlugin.java
Outdated
Show resolved
Hide resolved
carstenartur
force-pushed
the
fixdeprecations
branch
3 times, most recently
from
755c6cf
to
41a997c
Compare
carstenartur
force-pushed
the
fixdeprecations
branch
from
41a997c
to
a32b2e3
Compare
jjohnstn
force-pushed
the
fixdeprecations
branch
from
a32b2e3
to
1fd8cf5
Compare
jjohnstn
force-pushed
the
fixdeprecations
branch
from
1fd8cf5
to
35c2cbf
Compare
jjohnstn
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fix some deprecations by doing what the deprecation message suggests.
How to test
Ideally nothing should change in behavior.
Author checklist