make "AllTests" more specific #1487
Open
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid duplicate class names to make it easier to find the right one
jjohnstn
reviewed
Jul 2, 2024
There was a problem hiding this comment.
I don't have a strong opinion on this unless if affects reporting (do the checks account for tests being renamed?). I notice that jdt.ui.tests use TestSuite in the name. This is done here for the NLSTestSuite, so, for example, maybe using CCPTestSuite vs AllRefactoringCCPTests might be more compact and to the point and be more consistent with jdt.ui.tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid duplicate class names to make it easier to find the right one