Remove whitespace in URL in 2 .exsd files #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spaces cause the test LinkTest.testAllLinks() to fail.
fedejeanne
force-pushed
the
bugs/561-platform-LinkTest.testAllLinks()
branch
from
4c6ee0c
to
113eef4
Compare
|
@fedejeanne sorry I didn't noticed this PR before, but looks like it does the same as #278 and can be closed. |
It happens :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spaces might be the reason the test
LinkTest.testAllLinks()is failing (see Ed's comment in #561).Sadly the easiest way to test this is by merging this PR and then letting the tests run in the repository eclipse.platform. This guide was intended to show how to run the tests locally, but it is outdated/unclear (any hints on how to improve the guide are also appreciated and I can test them and push them in another PR).