Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove left overs from implementing version 0.7.0 of the JSR 305 spec #819

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

stephan-herrmann
Copy link
Contributor

Fixes #818

Code changes:

  • impl of JLS 18.5.3 refreshed from Java 19 spec
  • small code unification towards PTB.getNonWildcardParameterization()

Test adjustments:

  • fewer captures created cause different capture-names
  • wildcards eliminated from some error messages

@stephan-herrmann
Copy link
Contributor Author

@mpalat let me know if I should hold back this PR in order to avoid conflicts with your work in the Java 20 branch.

@mpalat
Copy link
Contributor

mpalat commented Mar 20, 2023

@mpalat let me know if I should hold back this PR in order to avoid conflicts with your work in the Java 20 branch.

@stephan-herrmann thanks for holding back especially since IC18 changes are non-trivial..

@stephan-herrmann stephan-herrmann added this to the 4.29 M1 milestone May 23, 2023
Fixes eclipse-jdt#818

Code changes:
- impl of JLS 18.5.3 refreshed from Java 19 spec
- small code unification towards PTB.getNonWildcardParameterization()

Test adjustments:
- fewer captures created cause different capture-names
- wildcards eliminated from some error messages
@stephan-herrmann stephan-herrmann merged commit 86cd859 into eclipse-jdt:master Jul 15, 2023
7 checks passed
@stephan-herrmann stephan-herrmann deleted the issue818 branch July 15, 2023 20:56
robstryker pushed a commit to robstryker/eclipse.jdt.core that referenced this pull request Jul 18, 2024
…eclipse-jdt#819)

Fixes eclipse-jdt#818

Code changes:
- impl of JLS 18.5.3 refreshed from Java 19 spec
- small code unification towards PTB.getNonWildcardParameterization()

Test adjustments:
- fewer captures created cause different capture-names
- wildcards eliminated from some error messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove left overs from implementing version 0.7.0 of the JSR 305 specification
2 participants