Remove unnecessary 'collectAllTypeBindings(...)' call #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzsombor
force-pushed
the
remove-unused-code
branch
from
5c088f1
to
f3eb1e1
Compare
jukzi
force-pushed
the
remove-unused-code
branch
from
f3eb1e1
to
2683dcf
Compare
iloveeclipse
force-pushed
the
remove-unused-code
branch
from
2683dcf
to
80db252
Compare
iloveeclipse
approved these changes
May 3, 2024
|
Thanks for the patch and sorry for long time not looking into this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
collectAllTypeBindings(...) is called unnecessarily, as the result is not used anywhere, and it seems, that collectAllTypeBindings doesn't mutate the objects, so it seems unnecessary
How to test
Trying code with sealed interfaces, etc
Author checklist