fix some ecj markers

Especially after moving files to compiler.batch - which has no resource warnings - the @SuppressWarnings("resource") is not used - leading to a marker
eclipse-jdt · Nov 30, 2023 · d4b1f26 · d4b1f26
1 parent 45f0152
commit d4b1f26
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 9 deletions.
diff --git a/JCL/converterJclMin9/src/java/lang/invoke/MethodHandle.java b/JCL/converterJclMin9/src/java/lang/invoke/MethodHandle.java
@@ -16,7 +16,6 @@
 
 import java.lang.annotation.Retention;
 import java.lang.annotation.Target;
-import java.lang.invoke.MethodType;
 
 public abstract class MethodHandle {
  @Target(METHOD)

diff --git a/JCL/converterJclMin9/src/java/lang/invoke/MethodHandles.java b/JCL/converterJclMin9/src/java/lang/invoke/MethodHandles.java
@@ -1,5 +1,4 @@
 package java.lang.invoke;
-import java.lang.invoke.MethodType;
 
 public class MethodHandles {
  public static final class Lookup {

diff --git a/org.eclipse.jdt.apt.tests/src/org/eclipse/jdt/apt/tests/MixedModeTesting.java b/org.eclipse.jdt.apt.tests/src/org/eclipse/jdt/apt/tests/MixedModeTesting.java
@@ -19,7 +19,6 @@
 import junit.framework.TestSuite;
 
 import org.eclipse.core.resources.IProject;
-import org.eclipse.core.runtime.CoreException;
 import org.eclipse.core.runtime.IPath;
 import org.eclipse.jdt.apt.core.internal.util.FactoryContainer;
 import org.eclipse.jdt.apt.core.internal.util.FactoryPath;

diff --git a/...h/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BatchAnnotationProcessorManager.java b/...h/src/org/eclipse/jdt/internal/compiler/apt/dispatch/BatchAnnotationProcessorManager.java
@@ -77,7 +77,7 @@ public void configure(Object batchCompiler, String[] commandLineArguments) {
  }
  BatchProcessingEnvImpl processingEnv = new BatchProcessingEnvImpl(this, (Main) batchCompiler, commandLineArguments);
  this._processingEnv = processingEnv;
- @SuppressWarnings("resource") // fileManager is not opened here
+ // @SuppressWarnings("resource") // fileManager is not opened here
  JavaFileManager fileManager = processingEnv.getFileManager();
  if (fileManager instanceof StandardJavaFileManager) {
  Iterable<? extends File> location = null;

diff --git a/...mpiler.batch/src/org/eclipse/jdt/internal/compiler/apt/dispatch/HookedJavaFileObject.java b/...mpiler.batch/src/org/eclipse/jdt/internal/compiler/apt/dispatch/HookedJavaFileObject.java
@@ -209,13 +209,13 @@ public HookedJavaFileObject(JavaFileObject fileObject, String fileName, String t
  this._typeName = typeName;
  }
 
- @SuppressWarnings("resource") // ForwardingOutputStream forwards close() too
+ // @SuppressWarnings("resource") // ForwardingOutputStream forwards close() too
  @Override
  public OutputStream openOutputStream() throws IOException {
  return new ForwardingOutputStream(super.openOutputStream());
  }
 
- @SuppressWarnings("resource") // ForwardingWriter forwards close() too
+ // @SuppressWarnings("resource") // ForwardingWriter forwards close() too
  @Override
  public Writer openWriter() throws IOException {
  return new ForwardingWriter(super.openWriter());

diff --git a/...dt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/tool/EclipseFileManager.java b/...dt.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/tool/EclipseFileManager.java
@@ -163,7 +163,7 @@ private void collectAllMatchingFiles(Location location, File file, String normal
  }
  }
  } else if (isArchive(file)) {
- @SuppressWarnings("resource") // cached archive is closed in EclipseFileManager.close()
+ // @SuppressWarnings("resource") // cached archive is closed in EclipseFileManager.close()
  Archive archive = this.getArchive(file);
  if (archive != Archive.UNKNOWN_ARCHIVE) {
  String key = normalizedPackageName;
@@ -442,7 +442,7 @@ public FileObject getFileForInput(Location location, String packageName, String
  return null;
  }
 
- @SuppressWarnings("resource") // cached archive is closed in EclipseFileManager.close()
+ // @SuppressWarnings("resource") // cached archive is closed in EclipseFileManager.close()
  private ArchiveFileObject getFileObject(File archiveFile, String normalizedFileName) {
  Archive archive = getArchive(archiveFile);
  if (archive == Archive.UNKNOWN_ARCHIVE) {
@@ -454,7 +454,7 @@ private ArchiveFileObject getFileObject(File archiveFile, String normalizedFileN
  return null;
  }
 
- @SuppressWarnings("resource") // cached archive is closed in EclipseFileManager.close()
+ // @SuppressWarnings("resource") // cached archive is closed in EclipseFileManager.close()
  private Boolean containsFileObject(File archiveFile, String normalizedFileName) {
  Archive archive = getArchive(archiveFile);
  if (archive == Archive.UNKNOWN_ARCHIVE) {

diff --git a/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTMatcherTest.java b/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTMatcherTest.java
@@ -1152,6 +1152,8 @@ public void testParenthesizedExpression() {
  ParenthesizedExpression x1 = this.ast.newParenthesizedExpression();
  basicMatch(x1);
  }
+
+ @SuppressWarnings("deprecation")
  public void testPatternInstanceofExpression() {
  if (this.ast.apiLevel() < AST.JLS17) {
  return;