Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Specify options for the build JVM only in Jenkins pipeline #559

Closed

Conversation

HannesWell
Copy link
Member

The options where introduced for all builds of the p2 repo via #464

Having it enabled can cause problems in GitHub workflows that are sensitive to the printout.

The options where introduced for all builds of the p2 repo via
eclipse-equinox#464

Having it enabled can cause problems in GitHub workflows that are
sensitive to the printout.
@laeubi
Copy link
Member

laeubi commented Oct 12, 2024

Having it enabled can cause problems in GitHub workflows that are sensitive to the printout.

Should then not better the GitHub workflows be fixed? I'm not sure that one should depend on any special output of the build pipeline...

@HannesWell
Copy link
Member Author

Having it enabled can cause problems in GitHub workflows that are sensitive to the printout.

Should then not better the GitHub workflows be fixed?

I think both is appropriated, as mentioned in #558 (comment)

For the GH workflows to build P2 e.g. the Xmx config is not necessary.

I'm not sure that one should depend on any special output of the build pipeline...

In hindsight this wasn't the best idea, but I followed to example given to me in eclipse-platform/eclipse.platform.releng.aggregator#2352 (comment) without thinking about this case. :)

Copy link

Test Results

  375 files  ±0    375 suites  ±0   43m 14s ⏱️ +54s
1 895 tests ±0  1 892 ✅ ±0  3 💤 ±0  0 ❌ ±0 
6 685 runs  ±0  6 676 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 361b345. ± Comparison against base commit e55cc8f.

@laeubi
Copy link
Member

laeubi commented Oct 12, 2024

For the GH workflows to build P2 e.g. the Xmx config is not necessary.

I think its always good to have Jenkins + Github as close as possible to verify things on different platforms.

@HannesWell
Copy link
Member Author

For the GH workflows to build P2 e.g. the Xmx config is not necessary.

I think its always good to have Jenkins + Github as close as possible to verify things on different platforms.

In general yes, but since these options were just added to fix failures on Jenkins I'm not sure if it might be better to just apply it to Jenkins. Especially since it now clutters all other builds.

What are the opinions of the others?
To fix the version-increment workflow this is not necessary anymore.

@HannesWell
Copy link
Member Author

Ok, let's keep it as it is for now.

@HannesWell HannesWell closed this Oct 14, 2024
@HannesWell HannesWell deleted the build-jvm-options branch October 14, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants