[Build] Simplify native build agent definition and platform list #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
simplify-build-agents
branch
4 times, most recently
from
4fbd241
to
07f5aab
Compare
HannesWell
force-pushed
the
simplify-build-agents
branch
from
07f5aab
to
6e1a8fa
Compare
HannesWell
force-pushed
the
simplify-build-agents
branch
from
6e1a8fa
to
59e8ffb
Compare
akurtakov
reviewed
Sep 15, 2024
| name: known-hosts | ||
| ''') { node(POD_LABEL) { stage(nativeBuildStageName) { container('launcherbuild') { body() } } } } | ||
| podTemplate(inheritFrom: 'centos-latest' /* inhert general configuration */, containers: [ | ||
| containerTemplate(name: 'launcherbuild', image: 'eclipse/platformreleng-centos-swt-build:8', |
There was a problem hiding this comment.
As centos 8 is deprecated and for gtk4 we are looking into moving to newer version it would be better to try with eclipse/platformreleng-centos-swt-build:9.
There was a problem hiding this comment.
I would like to do that in a separate PR dedicated only to that especially since using centos-9 has the non-trivial implications.
Btw. inheritFrom: 'centos-latest' to inherit the very basic configuration like volumes, credentials etc. The image used is the one specified in the line below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.