Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#652 Handle @user.home in -eclipse.password file retrieval #653

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

mPorhel
Copy link
Contributor

@mPorhel mPorhel commented Jul 2, 2024

No description provided.

Copy link

github-actions bot commented Jul 2, 2024

Test Results

  660 files  ±0    660 suites  ±0   1h 12m 31s ⏱️ - 1m 31s
2 195 tests ±0  2 148 ✅ ±0   47 💤 ±0  0 ❌ ±0 
6 729 runs  ±0  6 586 ✅ ±0  143 💤 ±0  0 ❌ ±0 

Results for commit 48a26b7. ± Comparison against base commit 61f32bd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the version, it looks fine.

@@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.equinox.security;singleton:=true
Bundle-Version: 1.4.300.qualifier
Bundle-Version: 1.4.301.qualifier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally increment by +100 in the master stream so that there is room for increments in a maintenance stream that don't overlap with the master stream's version.

https://github.com/eclipse-platform/eclipse.platform/blob/master/docs/VersionNumbering.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointer Ed.

@merks merks merged commit f582f10 into eclipse-equinox:master Jul 2, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants