back-port: use stronger cipher for secure storage #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pushed a commit to accommodate a change that we missed in the original PR. see eclipse-equinox/equinox#316 |
|
/cc @tjwatson could this be reviewed / landed? |
tjwatson
reviewed
Feb 5, 2024
bundles/org.eclipse.equinox.security.tests/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
gireeshpunathil
force-pushed
the
stronger-cipher
branch
from
ae566bf
to
0a5a179
Compare
tjwatson
reviewed
Feb 5, 2024
tjwatson
reviewed
Feb 5, 2024
tjwatson
reviewed
Feb 5, 2024
tjwatson
reviewed
Feb 5, 2024
move the default from weaker MD5/DES to a stronger SHA/AES which is available in JVMs. PBEWithMD5AndDES -> PBEWithHmacSHA512AndAES_256
gireeshpunathil
force-pushed
the
stronger-cipher
branch
from
0a5a179
to
afcf992
Compare
|
@tjwatson - made those changes, pls take another look. learning a lot in versioning! |
|
Collaborators - PR is approved, let me know if there is anything pending here, or else pls do the needful to land, and then I can build a patch and deliver to my user who asked for it. thanks in advance! |
tjwatson
merged commit 17dbb7d
into
eclipse-equinox:R4_23_maintenance
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move the default from weaker MD5/DES to a stronger SHA/AES which is available in JVMs.
PBEWithMD5AndDES -> PBEWithHmacSHA512AndAES_256
Refs: eclipse-equinox/equinox#285
/cc @tjwatson