Fix conflict around CommonMark versions since Eclipse 2024-12 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that with the target platform set to Eclipse 2024-12, the test.acceptance project is using the old copy of Hamcrest that is in JUnit 4, instead of Hamcrest 3.0, so we don't have access to containsString. Ideally we'd like to move to JUnit 5, which drops its embedded copy of Hamcrest altogether, but that would require rewriting many tests, so we can hold off on this until we start work on 2.7. Alternatively, we could stop using the centralised test.dependencies project and start to move tests gradually to JUnit 5. That is for later, though.
|
Waiting for CI tests to run in Github and Jenkins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #144. As the reporter mentioned, Picto was on an old version of CommonMark for Java (0.15.0) and it was conflicting with the 0.24.0 version being used in Eclipse 2024-12.
This PR upgrades the target platform to 2024-12, and switches to the CommonMark 0.24.0 release in the Orbit SimRel 2024-12 update site.