Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving IDL generator with structs inheritance which identifiers are Python keywords #174

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Bit-Seq
Copy link

@Bit-Seq Bit-Seq commented Nov 29, 2022

Solved the error detailed on #173.

@thijsmie
Copy link
Contributor

Thanks @Bit-Seq! I think this change is okay, we are just having some CI troubles right now. I'll rerun when that is resolved and come back to this PR.

@Bit-Seq
Copy link
Author

Bit-Seq commented Nov 29, 2022

Struct inheritance tests are in https://github.com/javiersorianoruiz/cyclonedds-python-checkReservedKeyword/tree/master/tests/. All the 007_test_X are related to it.

@Bit-Seq
Copy link
Author

Bit-Seq commented Dec 14, 2022

Hello!

Have you been able to solve CI troubles?

We (@jordialexalar and me) have created tests related to reserved Python keywords support using pytest. For a mistake we have added this file in the same fork as the pull requests pending to merge. All pull requests are connected, and also with the issues #105, #162, #163, #172 and #173.

Sorry for the inconvenience. If there is any problem we can create another fork and pull request with the tests.

Regards.

@thijsmie
Copy link
Contributor

Hi @Bit-Seq,

Yeah I did but the PR has not been reviewed yet (see #176). As soon as that is merged rerunning this should also succeed.

@eboasson
Copy link
Contributor

I was discussing the status of this PR with @noxpardalis and triggered a custom run of the CI for this PR to confirm that all is well with #176 merged, but it turns out there is some problem: https://dev.azure.com/eclipse-cyclonedds/cyclonedds-python/_build/results?buildId=3867&view=results . The results of this run are not visible on GitHub because, well, reasons, but if I am not mistaken I started it the right way.

I haven't looked at all the failures, but my sample suggests it consistently fails in the test_datatypes_keywords tests. I haven't dug into it (too many things to do, too little time ...), but would you perchance have some time to look into it, @Bit-Seq ?

On a side note: if the test run were successful, merging it would still be blocked anyway on the Eclipse Contributor Agreement verification.

@eboasson eboasson closed this Feb 17, 2023
@eboasson eboasson reopened this Feb 17, 2023
@eboasson
Copy link
Contributor

Cat on keyboard 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants