Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inheritance in cyclonedds-python not working properly after last commits in the master #172

Open
Bit-Seq opened this issue Nov 29, 2022 · 3 comments

Comments

@Bit-Seq
Copy link

Bit-Seq commented Nov 29, 2022

Hello,

After downloading the master of cyclonedss and cyclonedds-python, and test structs' inheritance, subscriber is not receiving any message.

If you test with the next IDL:

module module_test {
    struct parent {
        char var;
    };
    struct child : parent {
        char var2;
    };
};

And subscriber tries to receive messages from parent, it works properly, but it is not able to receive messages from child.

It seems that the changes done by @thijsmie on issue #162 solved the problem, but commits from the last days have caused the problem.

Best regards.

@Bit-Seq Bit-Seq changed the title Inheritance in cyclonedds-python not working properly after last changes in the master Inheritance in cyclonedds-python not working properly after last commits in the master Nov 29, 2022
@Bit-Seq
Copy link
Author

Bit-Seq commented Nov 29, 2022

Sorry, I had a configuration error in some tests from my battery. Issue closed.

@Bit-Seq Bit-Seq closed this as completed Nov 29, 2022
@thijsmie
Copy link
Contributor

Well actually there is an issue which I discovered due to looking into this! So I've added a test and fixed the fact that the structs base type was not included in the XTypes type information. The work in progress is here: https://github.com/thijsmie/cyclonedds-python/tree/172-struct-inheritance

We will merge once we've resolved some CI trouble and I've also fixed the fact that cyclonedds typeof doesn't properly support inheritance either.

@thijsmie thijsmie reopened this Nov 29, 2022
@Bit-Seq
Copy link
Author

Bit-Seq commented Nov 30, 2022

If it helps, we downloaded the master branch from cyclonedss and cyclonedss-python on November 28th and 29th and structs inheritance was working correctly on our tests https://github.com/javiersorianoruiz/cyclonedds-python-checkReservedKeyword/tree/master/tests/ (007_test_X).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants