Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update E2E 'factory' tests according new UI changes #22588

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Update E2E 'factory' tests according new UI changes #22588

merged 5 commits into from
Oct 11, 2023

Conversation

artaleks9
Copy link
Contributor

@artaleks9 artaleks9 commented Oct 9, 2023 •
edited
Loading

What does this PR do?

  • Fixes the problem with open the file 'Date.txt' in the editor:
Make changes to the file:
19:50:49       TreeItemNotFoundError: Item 'Date.txt' not found. Available items in current directory: [Date.txt,README.md,devfile.yaml,public-bb-repo]
  • Fixex the problem with 'Push the changes' in editor:
Push the changes:
     TimeoutError: Waiting for element to be located By(xpath, .//li[@title='Push 1 commits to origin/master'])
Wait timed out after 1119ms
  • Fixes the problem with ''Check if the changes were pushed':
Check if the changes were pushed:
     AssertionError: expected 'true' to be true

Screenshot/screencast of this PR

e2e-factory-push-fail-locator

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4909
https://issues.redhat.com/browse/CRW-4916

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Oct 9, 2023
@artaleks9 artaleks9 changed the title [WIP] Update E2E 'factory' tests according new UI changes Update E2E 'factory' tests according new UI changes Oct 9, 2023
@che-bot che-bot added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 9, 2023
@nallikaea nallikaea merged commit 080f22f into main Oct 11, 2023
3 checks passed
@nallikaea nallikaea deleted the crw-4909 branch October 11, 2023 08:46
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nallikaea nallikaea nallikaea approved these changes

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt

@ScrewTSW ScrewTSW Awaiting requested review from ScrewTSW

@dmytro-ndp dmytro-ndp Awaiting requested review from dmytro-ndp dmytro-ndp is a code owner

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artaleks9 @musienko-maxim @nallikaea @che-bot