Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Automate Workspace stopping by idle timeout test-case #22552

Merged
merged 4 commits into from
Oct 10, 2023
Merged

[Test] Automate Workspace stopping by idle timeout test-case #22552

merged 4 commits into from
Oct 10, 2023

Conversation

SkorikSergey
Copy link
Contributor

@SkorikSergey SkorikSergey commented Sep 26, 2023 •
edited
Loading

What does this PR do?

We need to automate Workspace stopping by idle timeout test-case. To set secondsOfInactivityBeforeIdling property in CheClaster(patch) use KubernetesCommandLineToolsExecutor and ShellExecutor classes.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-4836

How to test this PR?

Test scenario:

  1. Set spec.devEnvironments.secondsOfInactivityBeforeIdling:180 in CheCluster
  2. Start workspace using VS Code Editor
  3. Wait 3+ minutes (it should be 60 minutes by default).
  4. Make sure test workspace status is stopped in Dashboard.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. area/qe labels Sep 26, 2023
@SkorikSergey SkorikSergey self-assigned this Sep 26, 2023
@che-bot che-bot added the target/branch Indicates that a PR will be merged into a branch other than master. label Sep 26, 2023
@SkorikSergey SkorikSergey force-pushed the checkIdleTimeout branch 4 times, most recently from eecc6a0 to 092e911 Compare September 29, 2023 09:13
@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Oct 9, 2023
@SkorikSergey SkorikSergey marked this pull request as ready for review October 9, 2023 09:16
@SkorikSergey SkorikSergey added status/in-progress This issue has been taken by an engineer and is under active development. and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Oct 9, 2023
@SkorikSergey SkorikSergey added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Oct 10, 2023
@SkorikSergey SkorikSergey merged commit d5f1527 into main Oct 10, 2023
3 checks passed
@SkorikSergey SkorikSergey deleted the checkIdleTimeout branch October 10, 2023 13:22
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Oct 10, 2023
dmytro-ndp
dmytro-ndp approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nallikaea nallikaea nallikaea approved these changes

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim musienko-maxim is a code owner

@nickboldt nickboldt Awaiting requested review from nickboldt

@ScrewTSW ScrewTSW Awaiting requested review from ScrewTSW

Assignees

@SkorikSergey SkorikSergey

Labels
area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SkorikSergey @dmytro-ndp @nallikaea @che-bot