Refactoring test codebase accordind to recomendations #22544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musienko-maxim
requested review from
nickboldt,
ScrewTSW and
dmytro-ndp
as code owners
che-bot
added
target/branch
9 tasks
nallikaea
reviewed
Sep 22, 2023
| @@ -70,30 +66,31 @@ suite('Workspace using a parent test suite', function (): void { | |||
| const firstExpectedQuickPick: QuickPickItem | undefined = await input.findQuickPick('1. This command from the devfile'); | |||
| const secondExpectedQuickPick: QuickPickItem | undefined = await input.findQuickPick('2. This command from the parent'); | |||
| expect(firstExpectedQuickPick).not.eqls(undefined); | |||
| expect(secondExpectedQuickPick).not.eqls(undefined); | |||
| expect(secondExpectedQuickPick).not.undefined; | |||
There was a problem hiding this comment.
expect(firstExpectedQuickPick).not.eqls(undefined);
expect(secondExpectedQuickPick).not.undefined;
could it be in one style?
| @@ -25,4 +26,11 @@ export class ShellExecutor { | |||
| Logger.debug(command); | |||
| return exec(command); | |||
| } | |||
| executeArbitraryShellScript(command: string): string { | |||
| const output: ShellString = this.executeCommand(command); | |||
There was a problem hiding this comment.
Lets add Logger.debug() to show when method was called?
| podName = executeArbitraryShellScript(getPodNameCommand); | ||
| const containerNames: string = executeArbitraryShellScript( | ||
| podName = shellExecutor.executeArbitraryShellScript(getPodNameCommand); | ||
| const containerNames: string = shellExecutor.executeArbitraryShellScript( | ||
| `${API_TEST_CONSTANTS.TS_API_TEST_KUBERNETES_COMMAND_LINE_TOOL} get pod ${podName} --output jsonpath=\'{.spec.containers[*].name}\'` | ||
| ); | ||
| expect(containerNames).contain('tools'); | ||
| expect(containerNames).contains('che-gateway'); |
There was a problem hiding this comment.
expect(containerNames).contain('tools');
expect(containerNames).contains('che-gateway');
expect(envList).contain('DEVFILE_ENV_VAR=true');
expect(envList).contain('PARENT_ENV_VAR=true');
this can be replaced with .and:
expect(envList).contains('DEVFILE_ENV_VAR=true').and.contains('PARENT_ENV_VAR=true');
musienko-maxim
force-pushed
the
CHE-22538
branch
from
4fac163
to
f0bda13
Compare
nallikaea
approved these changes
Sep 25, 2023
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Apple changes according to the comments in the #22506 and #22538
Screenshot/screencast of this PR
What issues does this PR fix or reference?
[
How to test this PR?
Set up all env vars and run with npm or yarn as usual
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.