Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRW-1121 Automate testing of links to documentation page in Dashboard #22497

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

nallikaea
Copy link
Contributor

@nallikaea nallikaea commented Sep 7, 2023

@nallikaea nallikaea changed the title WIP: CRW-1121 WIP: CRW-1121 Automate testing of links to documentation page in Dashboard Sep 7, 2023
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Sep 7, 2023
@dmytro-ndp
Copy link
Contributor

@nallikaea nallikaea changed the title WIP: CRW-1121 Automate testing of links to documentation page in Dashboard CRW-1121 Automate testing of links to documentation page in Dashboard Sep 8, 2023
@nallikaea
Copy link
Contributor Author

@nallikaea: I would suggest adding support of testing Dev Spaces specific titles and links https://github.com/redhat-developer/devspaces-images/blob/devspaces-3-rhel-8/devspaces-dashboard/packages/dashboard-frontend/assets/branding/product.json

Thank you!
Will get documentation links from this file.

@nallikaea
Copy link
Contributor Author

@dmytro-ndp
Verification of Username added to suite. Suffix Locator returned in function name. Suit passed in 31s:

image

@nallikaea
Copy link
Contributor Author

formattig of package.json was updated because of this commit cf03445

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@nallikaea nallikaea merged commit 17b7a3e into eclipse-che:main Sep 21, 2023
2 checks passed
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants