-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set SAAS Gitlab url if endpint is not defined #733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinokurig can we possibly add a test for that?
done |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ibuziuk, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.18 :: server_3.x/369: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7956: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.x/5015: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8034: server : 3.x :: Build 65554675 : quay.io/devspaces/server-rhel8:3.18-8 |
Build 3.18 :: update-digests_3.x/7883: Console, Changes, Git Data |
Build 3.18 :: server_3.x/369: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7956 triggered |
Build 3.18 :: operator-bundle_3.x/3763: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7957: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.x/8035: devspaces-operator-bundle : 3.x :: Failed in 65555982 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
Fixes a bug when having gitlab and github oauth configured and GitHub oauth token is fetched, Server Exception is thrown.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23211
How to test this PR?
quay.io/eclipse/che-server:pr-733
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedRelease Notes
N/A
Reviewers
Reviewers, please comment how you tested the PR when approving it.