Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SAAS Gitlab url if endpint is not defined #733

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Set SAAS Gitlab url if endpint is not defined #733

merged 1 commit into from
Oct 30, 2024

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Oct 30, 2024

What does this PR do?

Fixes a bug when having gitlab and github oauth configured and GitHub oauth token is fetched, Server Exception is thrown.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23211

How to test this PR?

  1. Deploy che with the pull request image: quay.io/eclipse/che-server:pr-733
  2. Configure GitHub oauth.
  3. Configure Gitlab oauth.
  4. Start a workspace from a GitHub repository with a devfile.
  5. Go back to the dashboard page and refresh the page
  6. See: Dashboard loads successfully.

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

N/A

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinokurig can we possibly add a test for that?

@vinokurig
Copy link
Contributor Author

@ibuziuk

can we possibly add a test for that?

done

Copy link

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk ibuziuk merged commit 63cc78d into main Oct 30, 2024
28 checks passed
@ibuziuk ibuziuk deleted the che-23211 branch October 30, 2024 15:12
@devstudio-release
Copy link

Build 3.18 :: server_3.x/369: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: server_3.x/369: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7956 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.x/8035: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 65555982 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to open a dashboard on the dogfooding cluster
3 participants