-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply strategic merge to workspace-preferences-configmap #723
Conversation
@akurinnoy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@artaleks9 @dmytro-ndp can you please verify this fix? |
Verified on Che with |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.18 :: server_3.x/363: Console, Changes, Git Data |
fix: apply strategic merge to workspace-preferences-configmap
Build 3.18 :: sync-to-downstream_3.x/7787: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.x/4963: Console, Changes, Git Data |
Build 3.18 :: get-sources-rhpkg-container-build_3.x/7787: server : 3.x :: Build 64794659 : quay.io/devspaces/server-rhel8:3.18-2 |
Build 3.18 :: update-digests_3.x/7693: Console, Changes, Git Data |
Build 3.18 :: server_3.x/363: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7787 triggered |
Build 3.18 :: operator-bundle_3.x/3652: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7788: Console, Changes, Git Data |
Build 3.18 :: push-latest-container-to-quay_3.x/4964: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7788: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7788 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.18 :: operator-bundle_3.x/3652: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7788 triggered |
Build 3.18 :: copyIIBsToQuay/2824: Console, Changes, Git Data |
Build 3.18 :: dsc_3.x/2012: Console, Changes, Git Data |
Build 3.18 :: update-digests_3.x/7693: Detected new images: rebuild operator-bundle |
Build 3.18 :: dsc_3.x/2012: 3.18.0-CI |
What does this PR do?
This PR fixes the bug that causes overwriting the data section of the
workspace-preferences-configmap
.Screenshot/screencast of this PR
n/a
What issues does this PR fix or reference?
fixes https://issues.redhat.com/browse/CRW-7179
fixes eclipse-che/che#23154
How to test this PR?
quay.io/okurinny/che-server:next
;PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedRelease Notes
Reviewers
Reviewers, please comment how you tested the PR when approving it.