Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply strategic merge to workspace-preferences-configmap #723

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR fixes the bug that causes overwriting the data section of the workspace-preferences-configmap.

Screenshot/screencast of this PR

n/a

What issues does this PR fix or reference?

fixes https://issues.redhat.com/browse/CRW-7179
fixes eclipse-che/che#23154

How to test this PR?

  1. Deploy the Eclipse Che (or DevSpaces) using this image: quay.io/okurinny/che-server:next;
  2. Configure OAuth2 for the Bitbucket Cloud https://eclipse.dev/che/docs/stable/administration-guide/configuring-oauth-2-for-the-bitbucket-cloud/;
  3. Launch a factory using a project URL from your Bitbucket Cloud;
  4. Decline the authorization prompt;
  5. At this point
    • the dashboard should proceed with creating the new workspace;
    • the Untrusted repository modal should not appear.

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Copy link

openshift-ci bot commented Sep 23, 2024

@akurinnoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v14-gitlab-with-oauth-setup-flow 04f0b76 link true /test v14-gitlab-with-oauth-setup-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@akurinnoy
Copy link
Contributor Author

@artaleks9 @dmytro-ndp can you please verify this fix?

@artaleks9
Copy link
Contributor

Verified on Che with quay.io/eclipse/che-server:pr-723
the functionality works properly

@artaleks9
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit e4d7256 into main Oct 4, 2024
27 of 28 checks passed
@akurinnoy akurinnoy deleted the fix-declined-auth-startup branch October 4, 2024 15:36
@devstudio-release
Copy link

Build 3.18 :: server_3.x/363: Console, Changes, Git Data

akurinnoy added a commit that referenced this pull request Oct 4, 2024
fix: apply strategic merge to workspace-preferences-configmap
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: server_3.x/363: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7787 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

dmytro-ndp pushed a commit that referenced this pull request Oct 4, 2024
)

fix: apply strategic merge to workspace-preferences-configmap
@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.18 :: sync-to-downstream_3.x/7788: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7788 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.18 :: operator-bundle_3.x/3652: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/7788 triggered

@devstudio-release
Copy link

Build 3.18 :: copyIIBsToQuay/2824: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.18 :: dsc_3.x/2012: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.18 :: update-digests_3.x/7693: SUCCESS

Detected new images: rebuild operator-bundle
* server; /DS_CI/operator-bundle_3.x/3652 triggered

@devstudio-release
Copy link

Build 3.18 :: dsc_3.x/2012: SUCCESS

3.18.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace does not run when is applied Refused OAuth authorization
5 participants