Simplify the Raw devfile filename check

[vinokurig]

What does this PR do?

Do not check the Raw devfile file name but check if the url ends with .yaml before using the Raw devfile url resolver.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#22368

How to test this PR?

1. Deploy che with the PR image: quay.io/eclipse/che-server:pr-548
2. In a public GitHub repository create a custom.yaml file with a simple devfile content:

schemaVersion: 2.2.0
metadata:
  name: test

3. Copy the Raw file location.
4. Start a workspace from the raw devfile location

See: workspace starts from the devfile.

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[dmytro-ndp]

I had followed test scenario described in PR description and successfully started workspace using factory link to RAW custom.yaml.

At the same time project was empty inside VS Code Editor, end it had been reproduced with che-server:next and Dev Spaces 3.8.0 on Dev Sandbox:

So, it seems to be another issue.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmytro-ndp, ibuziuk, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@vinokurig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v12-github-with-pat-setup-flow	f13bde0	link	true	/test v12-github-with-pat-setup-flow
ci/prow/v12-gitlab-no-pat-oauth-flow	f13bde0	link	true	/test v12-gitlab-no-pat-oauth-flow
ci/prow/v12-bitbucket-no-pat-oauth-flow	f13bde0	link	true	/test v12-bitbucket-no-pat-oauth-flow
ci/prow/v12-gitlab-with-pat-setup-flow	f13bde0	link	true	/test v12-gitlab-with-pat-setup-flow
ci/prow/v12-github-no-pat-oauth-flow	f13bde0	link	true	/test v12-github-no-pat-oauth-flow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[devstudio-release]

Build 3.10 :: server_3.x/212: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: server_3.x/213: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: sync-to-downstream_3.x/4354: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4186: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4186:

server : 3.x :: Failed in 55145861 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

[devstudio-release]

Build 3.10 :: sync-to-downstream_3.x/4355: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4187: Console, Changes, Git Data

[devstudio-release]

Build 3.10 :: get-sources-rhpkg-container-build_3.x/4187:

server : 3.x :: Failed in 55145886 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay