Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement an ability to start workspaces in Safe Mode #896

Merged
merged 10 commits into from
Aug 29, 2023
Merged

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Aug 14, 2023

What does this PR do?

Implement an ability to start workspaces in Safe Mode.

What issues does this PR fix or reference?

eclipse-che/che#22228, eclipse-che/che#22391 and eclipse-che/che#22274

Is it tested? How?

  1. Deploy Eclipse-CHE with an image from the current PR.
  2. Open the 'Create Workspace' page. Create a new workspace with URL{CHE-Server}#https://github.com/olexii4/che-dashboard.git.
  3. Waite for an error message:
    Знімок екрана 2023-08-14 о 21 46 12
  4. Click the "Restart in Safe mode" button.
  5. Wait for the target workspace to restart and open IDE.
    Знімок екрана 2023-08-14 о 21 48 32
    Знімок екрана 2023-08-14 о 22 03 57

@che-bot
Copy link
Contributor

che-bot commented Aug 14, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896

@eclipse-che eclipse-che deleted a comment from codecov bot Aug 15, 2023
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896

@eclipse-che eclipse-che deleted a comment from codecov bot Aug 15, 2023
@openshift-ci openshift-ci bot removed the lgtm label Aug 16, 2023
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #896 (5946753) into main (c048151) will decrease coverage by 0.08%.
Report is 7 commits behind head on main.
The diff coverage is 78.22%.

@@            Coverage Diff             @@
##             main     #896      +/-   ##
==========================================
- Coverage   81.73%   81.65%   -0.08%     
==========================================
  Files         347      348       +1     
  Lines       36032    36430     +398     
  Branches     2263     2299      +36     
==========================================
+ Hits        29450    29747     +297     
- Misses       6558     6659     +101     
  Partials       24       24              
Flag Coverage Δ
unittests 81.65% <78.22%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../CommonSteps/CheckRunningWorkspacesLimit/index.tsx 91.69% <ø> (-0.10%) ⬇️
...rkspaceProgress/StartingSteps/Initialize/index.tsx 89.86% <ø> (-0.19%) ⬇️
...ogress/StartingSteps/WorkspaceConditions/index.tsx 84.78% <ø> (+2.38%) ⬆️
...s/dashboard-frontend/src/store/Workspaces/index.ts 56.41% <27.77%> (-1.63%) ⬇️
...aceProgress/StartingSteps/StartWorkspace/index.tsx 88.00% <56.41%> (-5.34%) ⬇️
...ages/dashboard-frontend/src/pages/Loader/index.tsx 94.81% <66.66%> (-4.34%) ⬇️
...ontend/src/store/Workspaces/devWorkspaces/index.ts 80.26% <75.84%> (-0.91%) ⬇️
...paceProgress/StartingSteps/OpenWorkspace/index.tsx 92.59% <84.61%> (-0.62%) ⬇️
...services/helpers/factoryFlow/buildFactoryParams.ts 96.87% <88.88%> (-1.02%) ⬇️
...paceProgress/CreatingSteps/Apply/Devfile/index.tsx 89.91% <90.62%> (-3.50%) ⬇️
... and 5 more

... and 2 files with indirect coverage changes

@dmytro-ndp
Copy link
Contributor

@olexii4: PR review results:

  1. IMHO it would be helpful to add the message / label to start workspace page that workspace is starting in safe mode with limited functionality.

  2. So that PR description said that it fixes Remove "Verbose" mode from UD che#22391, I made sure that there are no "Open in Verbose mode" items in left panel and workspaces page in Dashboard

  3. I have successfully executed steps from section "Is it tested? How?".
    Notes:
    3.1 Extensions view was broken and failed to obtain list of extensions: "Error while fetching extensions. Server returned 500":
    Screenshot from 2023-08-17 13-12-37
    There was no such a problem when create regular workspace from Dashboard.

3.2 eclipse-che/che#22228 contains requirements to workspace which is run in safe mode:

  • ephemeral storage
    currently workspace started using per-user storage:
    screenshot-eclipse-che apps ocp413-dnochev crw-qe com-2023 08 17-13_25_40
  • no route/ingress is created (the editor endpoints with urlRewriteSupport: false are ignored)
    there were 3 routes created when start workspace in safe mode:
    Screenshot from 2023-08-17 13-40-35

@olexii4
Copy link
Contributor Author

olexii4 commented Aug 17, 2023

@dmytro-ndp

3. I have successfully executed steps from section "Is it tested? How?".
Notes:
3.1 Extensions view was broken and failed to obtain list of extensions: "Error while fetching extensions. Server returned 500":

It is not an issue with this PR. We have the same problems with dogfooding:

Знімок екрана 2023-08-17 о 15 30 46

@dmytro-ndp
Copy link
Contributor

@olexii4 : thanks for the comments.
I have opened a ticket about popular extensions problem: eclipse-che/che#22439

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

New changes are detected. LGTM label has been removed.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896

@openshift-ci
Copy link

openshift-ci bot commented Aug 29, 2023

@olexii4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-images c7aa432 link true /test v11-images
ci/prow/v11-dashboard-happy-path c7aa432 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896

@olexii4
Copy link
Contributor Author

olexii4 commented Aug 29, 2023

I have added several fixes:

  1. Renamed 'Restart in Safe mode' -> 'Restart with default Devfile'
  2. Removed 'Open in Debug mode' from the factory flow.

Знімок екрана 2023-08-29 о 20 31 36

Знімок екрана 2023-08-29 о 23 52 00

@olexii4 olexii4 merged commit 3847277 into main Aug 29, 2023
9 checks passed
@olexii4 olexii4 deleted the CHE-22228 branch August 29, 2023 21:01
@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/306: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/4067: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/306: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4261 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/1788: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: sync-to-downstream_3.x/4263: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4117 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.9 :: operator-bundle_3.x/1890: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/4263 triggered

@devstudio-release
Copy link

Build 3.9 :: dsc_3.x/1283: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/4067: SUCCESS

Detected new images: rebuild operator-bundle
* code
* configbump
* dashboard
* devfileregistry
* devspaces-operator
* idea
* imagepuller
* machineexec
* pluginregistry
* server
* traefik
* udi; /DS_CI/operator-bundle_3.x/1890 triggered

@devstudio-release
Copy link

Build 3.9 :: dsc_3.x/1283: SUCCESS

3.9.0 CI

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/1788: SUCCESS

3.9
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.9-216
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-565561-533291-s390x
  + quay.io/devspaces/iib:3.9-v4.13-565761-533286-s390x
  + quay.io/devspaces/iib:3.9-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.9-v4.12-565756-533281-s390x
  + quay.io/devspaces/iib:3.9-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.9-v4.11-565747-533277-s390x
  + quay.io/devspaces/iib:3.9-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.9-v4.10-565743-533276-s390x
  + quay.io/devspaces/iib:3.9-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-565561-533291-ppc64le
  + quay.io/devspaces/iib:3.9-v4.13-565761-533286-ppc64le
  + quay.io/devspaces/iib:3.9-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.9-v4.12-565756-533281-ppc64le
  + quay.io/devspaces/iib:3.9-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.9-v4.11-565747-533277-ppc64le
  + quay.io/devspaces/iib:3.9-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.9-v4.10-565743-533276-ppc64le
  + quay.io/devspaces/iib:3.9-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.9-v4.14-565561-533291-x86_64
  + quay.io/devspaces/iib:3.9-v4.13-565761-533286-x86_64
  + quay.io/devspaces/iib:3.9-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.9-v4.12-565756-533281-x86_64
  + quay.io/devspaces/iib:3.9-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.9-v4.11-565747-533277-x86_64
  + quay.io/devspaces/iib:3.9-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.9-v4.10-565743-533276-x86_64
  + quay.io/devspaces/iib:3.9-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants