-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement an ability to start workspaces in Safe Mode #896
Conversation
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896 |
…paces in Safe Mode
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896 |
Codecov Report
@@ Coverage Diff @@
## main #896 +/- ##
==========================================
- Coverage 81.73% 81.65% -0.08%
==========================================
Files 347 348 +1
Lines 36032 36430 +398
Branches 2263 2299 +36
==========================================
+ Hits 29450 29747 +297
- Misses 6558 6659 +101
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@olexii4: PR review results:
3.2 eclipse-che/che#22228 contains requirements to workspace which is run in safe mode: |
It is not an issue with this PR. We have the same problems with dogfooding: |
@olexii4 : thanks for the comments. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896 |
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896 |
@olexii4: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-896 |
Build 3.9 :: dashboard_3.x/306: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/4261: Console, Changes, Git Data |
Build 3.9 :: push-latest-container-to-quay_3.x/3072: Console, Changes, Git Data |
Build 3.9 :: get-sources-rhpkg-container-build_3.x/4115: dashboard : 3.x :: Build 54978615 : quay.io/devspaces/dashboard-rhel8:3.9-13 |
Build 3.9 :: update-digests_3.x/4067: Console, Changes, Git Data |
Build 3.9 :: dashboard_3.x/306: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4261 triggered |
Build 3.9 :: operator-bundle_3.x/1890: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/4263: Console, Changes, Git Data |
Build 3.9 :: push-latest-container-to-quay_3.x/3073: Console, Changes, Git Data |
Build 3.9 :: copyIIBsToQuay/1788: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/4263: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/4117 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.9 :: operator-bundle_3.x/1890: Upstream sync done; /DS_CI/sync-to-downstream_3.x/4263 triggered |
Build 3.9 :: dsc_3.x/1283: Console, Changes, Git Data |
Build 3.9 :: update-digests_3.x/4067: Detected new images: rebuild operator-bundle |
Build 3.9 :: dsc_3.x/1283: 3.9.0 CI |
What does this PR do?
Implement an ability to start workspaces in Safe Mode.
What issues does this PR fix or reference?
eclipse-che/che#22228, eclipse-che/che#22391 and eclipse-che/che#22274
Is it tested? How?
URL{CHE-Server}#https://github.com/olexii4/che-dashboard.git
.