-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: code refactoring #885
Conversation
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-885 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-885 |
Codecov Report
@@ Coverage Diff @@
## main #885 +/- ##
==========================================
+ Coverage 81.53% 81.67% +0.13%
==========================================
Files 347 347
Lines 35977 35901 -76
Branches 2248 2239 -9
==========================================
- Hits 29333 29321 -12
+ Misses 6622 6558 -64
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Build 3.9 :: dashboard_3.x/290: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/3857: Console, Changes, Git Data |
Build 3.9 :: push-latest-container-to-quay_3.x/2802: Console, Changes, Git Data |
Build 3.9 :: get-sources-rhpkg-container-build_3.x/3706: dashboard : 3.x :: Build 54403616 : quay.io/devspaces/dashboard-rhel8:3.9-4 |
Build 3.9 :: update-digests_3.x/3827: Console, Changes, Git Data |
Build 3.9 :: dashboard_3.x/290: Upstream sync done; /DS_CI/sync-to-downstream_3.x/3857 triggered |
Build 3.9 :: operator-bundle_3.x/1649: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/3858: Console, Changes, Git Data |
Build 3.9 :: push-latest-container-to-quay_3.x/2803: Console, Changes, Git Data |
Build 3.9 :: copyIIBsToQuay/1585: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/3858: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3707 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.9 :: operator-bundle_3.x/1649: Upstream sync done; /DS_CI/sync-to-downstream_3.x/3858 triggered |
Build 3.9 :: update-digests_3.x/3827: Detected new images: rebuild operator-bundle |
Build 3.9 :: dsc_3.x/1074: Console, Changes, Git Data |
Build 3.9 :: dsc_3.x/1074: 3.9.0 CI |
Build 3.9 :: dashboard_3.x/291: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/3896: Console, Changes, Git Data |
Build 3.9 :: push-latest-container-to-quay_3.x/2846: Console, Changes, Git Data |
Build 3.9 :: get-sources-rhpkg-container-build_3.x/3750: dashboard : 3.x :: Build 54462686 : quay.io/devspaces/dashboard-rhel8:3.9-5 |
Build 3.9 :: dashboard_3.x/291: Upstream sync done; /DS_CI/sync-to-downstream_3.x/3896 triggered |
Build 3.9 :: update-digests_3.x/3860: Console, Changes, Git Data |
Build 3.9 :: operator-bundle_3.x/1682: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/3910: Console, Changes, Git Data |
Build 3.9 :: push-latest-container-to-quay_3.x/2856: Console, Changes, Git Data |
Build 3.9 :: copyIIBsToQuay/1618: Console, Changes, Git Data |
Build 3.9 :: sync-to-downstream_3.x/3910: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3764 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.9 :: operator-bundle_3.x/1682: Upstream sync done; /DS_CI/sync-to-downstream_3.x/3910 triggered |
Build 3.9 :: update-digests_3.x/3860: Detected new images: rebuild operator-bundle |
Build 3.9 :: dsc_3.x/1108: Console, Changes, Git Data |
Build 3.9 :: dsc_3.x/1108: 3.9.0 CI |
What does this PR do?
Factory flow code refactoring.
What issues does this PR fix or reference?
It needs for eclipse-che/che#22228