Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code refactoring #885

Merged
merged 2 commits into from
Aug 3, 2023
Merged

fix: code refactoring #885

merged 2 commits into from
Aug 3, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Aug 2, 2023

What does this PR do?

Factory flow code refactoring.

What issues does this PR fix or reference?

It needs for eclipse-che/che#22228

@che-bot
Copy link
Contributor

che-bot commented Aug 2, 2023

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Orel <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-885

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Aug 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2023

New changes are detected. LGTM label has been removed.

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-885

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #885 (5898f1f) into main (bd384a3) will increase coverage by 0.13%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #885      +/-   ##
==========================================
+ Coverage   81.53%   81.67%   +0.13%     
==========================================
  Files         347      347              
  Lines       35977    35901      -76     
  Branches     2248     2239       -9     
==========================================
- Hits        29333    29321      -12     
+ Misses       6622     6558      -64     
  Partials       22       22              
Flag Coverage Δ
unittests 81.67% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ss/CreatingSteps/CheckExistingWorkspaces/index.tsx 91.48% <ø> (+0.76%) ⬆️
...ceProgress/CreatingSteps/CreateWorkspace/index.tsx 95.65% <ø> (-0.30%) ⬇️
...rkspaceProgress/CreatingSteps/Initialize/index.tsx 95.50% <ø> (-0.18%) ⬇️
...aceProgress/StartingSteps/StartWorkspace/index.tsx 94.34% <ø> (-0.19%) ⬇️
...ogress/StartingSteps/WorkspaceConditions/index.tsx 86.47% <ø> (-0.13%) ⬇️
.../CommonSteps/CheckRunningWorkspacesLimit/index.tsx 91.71% <100.00%> (+0.93%) ⬆️
...paceProgress/CreatingSteps/Apply/Devfile/index.tsx 93.33% <100.00%> (-0.11%) ⬇️
...ceProgress/CreatingSteps/Apply/Resources/index.tsx 96.01% <100.00%> (-0.10%) ⬇️
...paceProgress/CreatingSteps/Fetch/Devfile/index.tsx 97.10% <100.00%> (-0.05%) ⬇️
...ceProgress/CreatingSteps/Fetch/Resources/index.tsx 95.65% <100.00%> (-0.15%) ⬇️
... and 4 more

@olexii4 olexii4 merged commit 549cd4e into main Aug 3, 2023
11 checks passed
@olexii4 olexii4 deleted the code_cleanup branch August 3, 2023 11:21
@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/290: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/3827: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/290: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3857 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/1585: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: sync-to-downstream_3.x/3858: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3707 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.9 :: operator-bundle_3.x/1649: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3858 triggered

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/3827: SUCCESS

Detected new images: rebuild operator-bundle
* code
* configbump
* dashboard
* devfileregistry; /DS_CI/operator-bundle_3.x/1649 triggered

@devstudio-release
Copy link

Build 3.9 :: dsc_3.x/1074: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: dsc_3.x/1074: SUCCESS

3.9.0 CI

@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/291: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: dashboard_3.x/291: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3896 triggered

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/3860: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.9 :: copyIIBsToQuay/1618: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: sync-to-downstream_3.x/3910: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3764 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.9 :: operator-bundle_3.x/1682: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3910 triggered

@devstudio-release
Copy link

Build 3.9 :: update-digests_3.x/3860: SUCCESS

Detected new images: rebuild operator-bundle
* code
* configbump
* dashboard
* devfileregistry
* devspaces-operator
* machineexec
* pluginregistry
* server
* traefik
* udi; /DS_CI/operator-bundle_3.x/1682 triggered

@devstudio-release
Copy link

Build 3.9 :: dsc_3.x/1108: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.9 :: dsc_3.x/1108: SUCCESS

3.9.0 CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants