Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workspace condition messages #884

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR restores showing workspace condition messages as starting steps.

Fixes regression in #878

@che-bot
Copy link
Contributor

che-bot commented Aug 1, 2023

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-884

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-884

@openshift-ci
Copy link

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #884 (599c90e) into main (3a6fff7) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
- Coverage   81.54%   81.53%   -0.02%     
==========================================
  Files         347      347              
  Lines       35962    35977      +15     
  Branches     2244     2248       +4     
==========================================
+ Hits        29325    29333       +8     
- Misses       6615     6622       +7     
  Partials       22       22              
Flag Coverage Δ
unittests 81.53% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rontend/src/components/WorkspaceProgress/index.tsx 93.20% <75.00%> (-1.07%) ⬇️

@akurinnoy akurinnoy merged commit bd384a3 into main Aug 1, 2023
9 of 11 checks passed
@akurinnoy akurinnoy deleted the fix-duplicate-requests branch August 1, 2023 14:59
akurinnoy added a commit that referenced this pull request Aug 1, 2023
akurinnoy added a commit that referenced this pull request Aug 2, 2023
Fix duplicating requests (#878)
fix: workspace condition messages (#884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants