Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve development flow with skaffold #869

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Improve development flow with skaffold #869

merged 3 commits into from
Jul 26, 2023

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Jul 19, 2023

What does this PR do?

This PR improves the development flow on the dogfooding cluster when it's needed to continuously update the dashboard on a remote cluster to review or test any changes. Skaffold is able to automate all steps needed, like building a new image, pushing the image to the repo, and then updating the CR.

Using scaffold on dogfooding cluster

https://youtu.be/MeXLKcX-mmU

What issues does this PR fix or reference?

resolves eclipse-che/che#22116

Is it tested? How?

  1. Create a new workspace using this link: https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/#https://github.com/eclipse-che/che-dashboard/tree/skaffold
  2. Log in to the remote cluster with Eclipse Che deployed.
  3. Log in to the container registry you want to use.
  4.  export DEFAULT_REPO=<your-registry>/<project-id>
  5. Do some changes in the che-dashboard project, and run yarn build.
  6. Run
    scaffold run --cleanup=false --default-repo=$DEFAULT_REPO
    Skaffold builds a new image, pushes it to the registry, and patches the CR.
  7. Watch changes you've made in the dashboard on the remote cluster.

Signed-off-by: Oleksii Kurinnyi <[email protected]>
@akurinnoy akurinnoy self-assigned this Jul 19, 2023
@che-bot
Copy link
Contributor

che-bot commented Jul 19, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-869

README.md Outdated Show resolved Hide resolved
skaffold.yaml Outdated Show resolved Hide resolved
devfile.yaml Show resolved Hide resolved
Signed-off-by: Oleksii Kurinnyi <[email protected]>
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-869

Signed-off-by: Oleksii Orel <[email protected]>
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-869

@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk
Copy link
Member

ibuziuk commented Jul 26, 2023

/retest

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #869 (7b1dfb1) into main (58cdd35) will decrease coverage by 0.01%.
Report is 9 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #869      +/-   ##
==========================================
- Coverage   81.59%   81.58%   -0.01%     
==========================================
  Files         347      347              
  Lines       35874    35881       +7     
  Branches     2230     2231       +1     
==========================================
+ Hits        29271    29275       +4     
- Misses       6581     6584       +3     
  Partials       22       22              
Flag Coverage Δ
unittests 81.58% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@ibuziuk ibuziuk merged commit 543d48c into main Jul 26, 2023
10 of 11 checks passed
@ibuziuk ibuziuk deleted the skaffold branch July 26, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Improve the development flow with skaffold.dev on dogfooding
4 participants