-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the bug when kubeconfig file content is collapsed to one line after workspace restart #1279
Conversation
@vinokurig Could you add the proper test for your changes(for the mergeKubeConfig method)? |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1279 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1279", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vinokurig would it be possible to add test(s) for that ?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
+ Coverage 91.69% 91.80% +0.10%
==========================================
Files 499 499
Lines 45651 45653 +2
Branches 3178 3187 +9
==========================================
+ Hits 41860 41912 +52
+ Misses 3760 3711 -49
+ Partials 31 30 -1 ☔ View full report in Codecov by Sentry. |
@vinokurig Could you fix the build-and-test checks, please? |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1279 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1279", name: che-dashboard}]}}]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Verified on Eclipse Che with |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, ibuziuk, olexii4, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.19 :: dashboard_3.x/607: Console, Changes, Git Data |
Build 3.19 :: sync-to-downstream_3.x/8346: Console, Changes, Git Data |
Build 3.19 :: get-sources-rhpkg-container-build_3.x/8442: dashboard : 3.x :: Failed in : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
oc
andkubectl
tools is YAML.Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23238
Is it tested? How?
quay.io/eclipse/che-dashboard:pr-1279
/home/user/.kube/config
file, see that the content is YAML.oc whoami
from the terminal.See: the oc command works, the kubeconfig file is valid.
Release Notes
Docs PR