Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update from ubi8/nodejs-18:1-127 to ubi8/nodejs-18:1-128 #1232

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

che-bot
Copy link
Contributor

@che-bot che-bot commented Oct 19, 2024

Signed-off-by: Nick Boldt [email protected]

@openshift-ci-robot
Copy link

@che-bot: No Jira issue with key nodejs-18 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Signed-off-by: Nick Boldt [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@che-bot
Copy link
Contributor Author

che-bot commented Oct 19, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1232

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1232", name: che-dashboard}]}}]"

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.02%. Comparing base (ee53494) to head (509f3f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1232      +/-   ##
==========================================
+ Coverage   89.84%   90.02%   +0.18%     
==========================================
  Files         445      445              
  Lines       45991    45991              
  Branches     3090     3108      +18     
==========================================
+ Hits        41319    41403      +84     
+ Misses       4636     4552      -84     
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Oct 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, che-bot, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akurinnoy akurinnoy merged commit 89eff66 into main Oct 22, 2024
20 checks passed
@akurinnoy akurinnoy deleted the pr-update-base-images-1729296288 branch October 22, 2024 13:40
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/574: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants