-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TemporaryStorageField widget #1215
Conversation
@olexii4 it looks like some unit tests failed, can you take a look? |
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1215 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1215", name: che-dashboard}]}}]" |
@akurinnoy I have fixed it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1215 +/- ##
==========================================
- Coverage 90.08% 89.76% -0.33%
==========================================
Files 443 443
Lines 45727 45716 -11
Branches 3078 3053 -25
==========================================
- Hits 41194 41037 -157
- Misses 4493 4642 +149
+ Partials 40 37 -3 ☔ View full report in Codecov by Sentry. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.18 :: dashboard_3.x/562: Console, Changes, Git Data |
Build 3.18 :: sync-to-downstream_3.x/7798: Console, Changes, Git Data |
What does this PR do?
This PR changes the temporary storage component id to prevent showing several components on the page with the same id.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes eclipse-che/che#23181
Is it tested? How?
Release Notes
Docs PR