Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TemporaryStorageField widget #1215

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: TemporaryStorageField widget #1215

merged 1 commit into from
Oct 9, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Oct 8, 2024

What does this PR do?

This PR changes the temporary storage component id to prevent showing several components on the page with the same id.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23181

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.
  2. Open Create Workspace page on the dashboard.
  3. Put a valid URL into the Git repo URL field.
  4. Try to switch temporary storage for samples.
  5. The temporary storage switch works as expected.
Знімок екрана 2024-10-08 о 18 17 08

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2024

Click here to review and test in web IDE: Contribute

@akurinnoy
Copy link
Contributor

@olexii4 it looks like some unit tests failed, can you take a look?

Copy link

github-actions bot commented Oct 8, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1215

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1215", name: che-dashboard}]}}]"

@olexii4
Copy link
Contributor Author

olexii4 commented Oct 8, 2024

@olexii4 it looks like some unit tests failed, can you take a look?

@akurinnoy I have fixed it.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.76%. Comparing base (5c42201) to head (2a31295).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...rd-backend/src/routes/api/devworkspaceResources.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
- Coverage   90.08%   89.76%   -0.33%     
==========================================
  Files         443      443              
  Lines       45727    45716      -11     
  Branches     3078     3053      -25     
==========================================
- Hits        41194    41037     -157     
- Misses       4493     4642     +149     
+ Partials       40       37       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 165b1f2 into main Oct 9, 2024
19 of 21 checks passed
@olexii4 olexii4 deleted the CHE-23182 branch October 9, 2024 10:19
@devstudio-release
Copy link

Build 3.18 :: dashboard_3.x/562: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UD] Temporary Storage switch does not work properly
4 participants