Show warning banner on user namespace FailedScheduling event #1211

vinokurig · 2024-10-04T13:22:22Z

What does this PR do?

Show the notification banner on the workspace startup screen, informing user that workspace startup would take longer due to a new node being provisioned.
Add a user namespace listener and catch the FaildedScheduling event:

{
  "New item": {
    "eventPhase": "ADDED",
    "event": {
      "kind": "Event",
      "apiVersion": "v1",
      "metadata": {
        "name": "workspace58a0cc9c0eb94bc1-58fd9c7f85-2fbb5.17fae4587f8d7c9c",
        "namespace": "che-kube-admin-che-374upj",
        "uid": "070256c7-eb1e-48bc-a796-5fdc419c34a8",
        "resourceVersion": "85282",
        "creationTimestamp": "2024-10-03T08:34:35Z",
        "managedFields": [
          {
            "manager": "kube-scheduler",
            "operation": "Update",
            "apiVersion": "events.k8s.io/v1",
            "time": "2024-10-03T08:34:35Z",
            "fieldsType": "FieldsV1",
            "fieldsV1": {
              "f:action": {},
              "f:eventTime": {},
              "f:note": {},
              "f:reason": {},
              "f:regarding": {},
              "f:reportingController": {},
              "f:reportingInstance": {},
              "f:type": {}
            }
          }
        ]
      },
      "involvedObject": {
        "kind": "Pod",
        "namespace": "che-kube-admin-che-374upj",
        "name": "workspace58a0cc9c0eb94bc1-58fd9c7f85-2fbb5",
        "uid": "a666e7c2-33dd-48f3-a6a9-fd7beeeace25",
        "apiVersion": "v1",
        "resourceVersion": "85280"
      },
      "reason": "FailedScheduling",
      "message": "0/6 nodes are available: 1 Insufficient memory, 2 node(s) were unschedulable, 3 node(s) had untolerated taint {node-role.kubernetes.io/master: }. preemption: 0/6 nodes are available: 1 No preemption victims found for incoming pod, 5 Preemption is not helpful for scheduling.",
      "source": {},
      "firstTimestamp": null,
      "lastTimestamp": null,
      "type": "Warning",
      "eventTime": "2024-10-03T08:34:35.798237Z",
      "action": "Scheduling",
      "reportingComponent": "default-scheduler",
      "reportingInstance": "default-scheduler-ip-10-0-104-158"
    }
  }
}

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#22598

Is it tested? How?

Configure DWOC to ignore FailedScheduling error during workspace startup:

apiVersion: controller.devfile.io/v1alpha1
config:
  workspace:
    ignoredUnrecoverableEvents:
      - FailedScheduling
    progressTimeout: 600s

Decrease the number of working nodes, by setting all theMachineSet yaml replicas to 0:

apiVersion: machine.openshift.io/v1beta1
kind: MachineSet
metadata:
  name: ****
spec:
  replicas: 0

Start a workspace, see:
Increase the number of working nodes back and wait until the workspace starts.

Release Notes

Show the notification banner on the workspace startup screen, informing user that workspace startup would take longer due to a new node being provisioned.

Docs PR

che-bot · 2024-10-04T13:22:35Z

Click here to review and test in web IDE:

github-actions · 2024-10-04T14:33:22Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1211

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1211", name: che-dashboard}]}}]"

codecov · 2024-10-04T16:50:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (449ee7c) to head (1434618).
Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
+ Coverage   89.80%   89.87%   +0.07%     
==========================================
  Files         443      444       +1     
  Lines       45793    45905     +112     
  Branches     3051     3069      +18     
==========================================
+ Hits        41126    41259     +133     
+ Misses       4631     4608      -23     
- Partials       36       38       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-10-07T09:40:35Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1211

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1211", name: che-dashboard}]}}]"

akurinnoy · 2024-10-07T12:50:54Z

packages/dashboard-frontend/src/components/BannerAlert/NoNodeAvailable/index.tsx

+  }
+
+  public async componentDidMount() {
+    const devWorkspaceListener: ChannelListener = message => {


Hi @vinokurig,
Can you use selectors for events and devWorkspaces instead of adding these WS listeners?
I mean selectAllEvents and selectAllDevWorkspaces

done, @akurinnoy please take a look

ibuziuk · 2024-10-07T13:23:00Z

packages/dashboard-frontend/src/components/BannerAlert/NoNodeAvailable/__tests__/index.spec.tsx

+
+const websocketClient = container.get(WebsocketClient);
+const text =
+  'Cluster autoscaler is provisioning a new node at the moment. Please be patient, workspace startup will be taking longer than usual.';


since we fall back on only the "FailedScheduling" event we should be more careful with wording since it might happen for different reasons

ibuziuk · 2024-10-07T13:29:45Z

packages/dashboard-frontend/src/components/BannerAlert/NoNodeAvailable/__tests__/index.spec.tsx

+
+const websocketClient = container.get(WebsocketClient);
+const text =
+  'Cluster autoscaler is provisioning a new node at the moment. Please be patient, workspace startup will be taking longer than usual.';


'FailedScheduling' event occurred. If cluster autoscaler is enabled it might be provisioning a new node now and workspace startup will take longer than usual. Check the 'Events' tab to get more details.

done, changed the screenshot image.

DId not add the Check the 'Events' tab to get more details. as the banner is also appears in the main dashboard page:

github-actions · 2024-10-07T19:00:17Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1211

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1211", name: che-dashboard}]}}]"

github-actions · 2024-10-07T19:06:54Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1211

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1211", name: che-dashboard}]}}]"

…22598

github-actions · 2024-10-10T13:29:05Z

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1211

kubectl patch command

kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1211", name: che-dashboard}]}}]"

olexii4

LGTM

openshift-ci · 2024-10-14T08:29:45Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

artaleks9 · 2024-10-14T14:00:02Z

Verified on Eclipse Che with quay.io/eclipse/che-dashboard:pr-1211 image
The functionality works properly

devstudio-release · 2024-10-15T09:38:27Z

Build 3.18 :: dashboard_3.x/569: Console, Changes, Git Data

devstudio-release · 2024-10-15T09:41:27Z

Build 3.18 :: sync-to-downstream_3.x/7824: Console, Changes, Git Data

devstudio-release · 2024-10-15T09:41:59Z

Build 3.18 :: get-sources-rhpkg-container-build_3.x/7836: Console, Changes, Git Data

Show the notification banner on the workspace startup screen, informing user that workspace startup would take longer due to a new node being provisioned.

vinokurig requested review from akurinnoy, olexii4 and ibuziuk as code owners October 4, 2024 13:22

vinokurig force-pushed the che-22598 branch from ac9021a to ff5a1da Compare October 4, 2024 14:22

vinokurig force-pushed the che-22598 branch 2 times, most recently from 27c042a to e75022a Compare October 7, 2024 08:36

Show warning banner on user namespace FailedScheduling event

2ebf776

vinokurig force-pushed the che-22598 branch from e75022a to 2ebf776 Compare October 7, 2024 09:30

akurinnoy reviewed Oct 7, 2024

View reviewed changes

ibuziuk reviewed Oct 7, 2024

View reviewed changes

fixup! Show warning banner on user namespace FailedScheduling event

762942d

vinokurig force-pushed the che-22598 branch from bf46295 to 762942d Compare October 7, 2024 18:56

ibuziuk approved these changes Oct 8, 2024

View reviewed changes

openshift-ci bot assigned ibuziuk Oct 8, 2024

openshift-ci bot added the lgtm label Oct 8, 2024

fixup! Show warning banner on user namespace FailedScheduling event

ed24266

openshift-ci bot removed the lgtm label Oct 9, 2024

vinokurig added 2 commits October 10, 2024 11:28

Merge branch 'main' of github.com:eclipse-che/che-dashboard into che-…

cedf82f

…22598

fixup! Show warning banner on user namespace FailedScheduling event

1434618

olexii4 approved these changes Oct 10, 2024

View reviewed changes

openshift-ci bot assigned olexii4 Oct 10, 2024

openshift-ci bot added the lgtm label Oct 10, 2024

akurinnoy approved these changes Oct 14, 2024

View reviewed changes

openshift-ci bot assigned akurinnoy Oct 14, 2024

vinokurig merged commit 50072a8 into main Oct 15, 2024
20 checks passed

vinokurig deleted the che-22598 branch October 15, 2024 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show warning banner on user namespace FailedScheduling event #1211

Show warning banner on user namespace FailedScheduling event #1211

vinokurig commented Oct 4, 2024 •

edited

Loading

che-bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

codecov bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 7, 2024

akurinnoy Oct 7, 2024

vinokurig Oct 10, 2024

ibuziuk Oct 7, 2024

ibuziuk Oct 7, 2024

vinokurig Oct 7, 2024

vinokurig Oct 7, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 10, 2024

olexii4 left a comment

openshift-ci bot commented Oct 14, 2024

artaleks9 commented Oct 14, 2024

devstudio-release commented Oct 15, 2024

devstudio-release commented Oct 15, 2024

devstudio-release commented Oct 15, 2024

Show warning banner on user namespace FailedScheduling event #1211

Show warning banner on user namespace FailedScheduling event #1211

Conversation

vinokurig commented Oct 4, 2024 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Is it tested? How?

Release Notes

Docs PR

che-bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

codecov bot commented Oct 4, 2024 • edited Loading

Codecov Report

github-actions bot commented Oct 7, 2024

akurinnoy Oct 7, 2024

Choose a reason for hiding this comment

vinokurig Oct 10, 2024

Choose a reason for hiding this comment

ibuziuk Oct 7, 2024

Choose a reason for hiding this comment

ibuziuk Oct 7, 2024

Choose a reason for hiding this comment

vinokurig Oct 7, 2024

Choose a reason for hiding this comment

vinokurig Oct 7, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 7, 2024

github-actions bot commented Oct 10, 2024

olexii4 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 14, 2024

artaleks9 commented Oct 14, 2024

devstudio-release commented Oct 15, 2024

devstudio-release commented Oct 15, 2024

devstudio-release commented Oct 15, 2024

vinokurig commented Oct 4, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading