fix: factory URL flow with untrusted repository #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Kurinnyi <[email protected]>
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1210 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1210", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
==========================================
- Coverage 91.37% 89.99% -1.39%
==========================================
Files 442 443 +1
Lines 45650 45729 +79
Branches 3060 3071 +11
==========================================
- Hits 41714 41154 -560
- Misses 3936 4542 +606
- Partials 0 33 +33 ☔ View full report in Codecov by Sentry. |
olexii4
reviewed
Oct 2, 2024
packages/dashboard-frontend/src/store/Workspaces/Preferences/helpers.ts
Outdated
Show resolved
Hide resolved
…elpers.ts Co-authored-by: Oleksii Orel <[email protected]>
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1210 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1210", name: che-dashboard}]}}]" |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.18 :: dashboard_3.x/560: Console, Changes, Git Data |
|
Build 3.18 :: sync-to-downstream_3.x/7785: Console, Changes, Git Data |
|
Build 3.18 :: push-latest-container-to-quay_3.x/4961: Console, Changes, Git Data |
|
Build 3.18 :: get-sources-rhpkg-container-build_3.x/7782: dashboard : 3.x :: Build 64784473 : quay.io/devspaces/dashboard-rhel8:3.18-2 |
|
Build 3.18 :: dashboard_3.x/560: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7785 triggered |
|
Build 3.18 :: update-digests_3.x/7690: Console, Changes, Git Data |
|
Build 3.18 :: operator-bundle_3.x/3651: Console, Changes, Git Data |
|
Build 3.18 :: sync-to-downstream_3.x/7786: Console, Changes, Git Data |
|
Build 3.18 :: push-latest-container-to-quay_3.x/4962: Console, Changes, Git Data |
|
Build 3.18 :: copyIIBsToQuay/2823: Console, Changes, Git Data |
|
Build 3.18 :: sync-to-downstream_3.x/7786: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/7783 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.18 :: operator-bundle_3.x/3651: Upstream sync done; /DS_CI/sync-to-downstream_3.x/7786 triggered |
|
Build 3.18 :: dsc_3.x/2011: Console, Changes, Git Data |
|
Build 3.18 :: update-digests_3.x/7690: Detected new images: rebuild operator-bundle |
|
Build 3.18 :: dsc_3.x/2011: 3.18.0-CI |
|
Build 3.18 :: copyIIBsToQuay/2823: 3.18 |
akurinnoy
added a commit
that referenced
this pull request
Oct 4, 2024
* fix: factory URL flow with untrusted repository Signed-off-by: Oleksii Kurinnyi <[email protected]> * Update packages/dashboard-frontend/src/store/Workspaces/Preferences/helpers.ts Co-authored-by: Oleksii Orel <[email protected]> --------- Signed-off-by: Oleksii Kurinnyi <[email protected]> Co-authored-by: Oleksii Orel <[email protected]>
dmytro-ndp
pushed a commit
that referenced
this pull request
Oct 4, 2024
* fix: factory URL flow with untrusted repository * Update packages/dashboard-frontend/src/store/Workspaces/Preferences/helpers.ts --------- Signed-off-by: Oleksii Kurinnyi <[email protected]> Co-authored-by: Oleksii Orel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a bug that blocks the creation of workspaces using a factory link to an untrusted repository.
Screenshot/screencast of this PR
Before
Screen.Recording.2024-10-01.at.15.15.27.mov
After
Screen.Recording.2024-10-01.at.15.09.28.mov
What issues does this PR fix or reference?
fixes eclipse-che/che#23146
Is it tested? How?
See the screencast above.
Release Notes
Docs PR