-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to edit/import gitconfig when no configmap exists #1204
Conversation
Signed-off-by: Oleksii Kurinnyi <[email protected]>
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
==========================================
- Coverage 91.35% 89.91% -1.45%
==========================================
Files 442 442
Lines 45650 45698 +48
Branches 3044 3060 +16
==========================================
- Hits 41704 41088 -616
- Misses 3946 4571 +625
- Partials 0 39 +39 ☔ View full report in Codecov by Sentry. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1204 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1204", name: che-dashboard}]}}]" |
packages/dashboard-backend/src/devworkspaceClient/services/gitConfigApi/__tests__/index.spec.ts
Outdated
Show resolved
Hide resolved
…ConfigApi/__tests__/index.spec.ts Co-authored-by: Oleksii Orel <[email protected]>
…ces/gitConfigApi/__tests__/index.spec.ts
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1204 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1204", name: che-dashboard}]}}]" |
@akurinnoy Could you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.17 :: dashboard_3.x/556: Console, Changes, Git Data |
Build 3.17 :: sync-to-downstream_3.x/7740: Console, Changes, Git Data |
What does this PR do?
If it does not exist, the Dashboard creates a
workspace-userdata-gitconfig-configmap
Configmap with a data section like thisThis will allow users to edit this Git configuration, or import the entire
.gitconfig
file.Screenshot/screencast of this PR
Screen.Recording.2024-09-26.at.13.10.06.mov
What issues does this PR fix or reference?
resolves eclipse-che/che#23147
Is it tested? How?
See screencast section
Release Notes
Docs PR