Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove doubled language configurations #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove doubled language configurations #28

wants to merge 1 commit into from

Conversation

ghentschke
Copy link
Contributor

@ghentschke ghentschke commented Mar 8, 2023 •
edited
Loading

Since org.eclipse.tm4e.language_pack comes along with CDT the org.eclipse.lsp plug-in does not need to hold language configuration files any more. There is one drawback: the language configuration definitions e.g. autoClosingPairs does not work for C++ standard header files without file extension.

@ghentschke
Copy link
Contributor Author

ghentschke commented Mar 8, 2023 •
edited
Loading

The build fails, because org.eclipse.tm4e.language_pack seems to be no part of Eclipse 2022-06.

Maybe we should do the removal later.

@ghentschke ghentschke force-pushed the clean-up-plugin branch 2 times, most recently from 97c09fd to 7121f37 Compare March 8, 2023 08:04
@jonahgraham
Copy link
Member

BTW, when working on TM4E I saw that the language_pack is now out of date in TM4E. I provided an update in eclipse-tm4e/tm4e#501 but I haven't verified if that solves/improves this issue.

@ghentschke
Copy link
Contributor Author

ghentschke commented Mar 8, 2023 •
edited
Loading

I provided an update in eclipse-tm4e/tm4e#501 but I haven't verified if that solves/improves this issue.

No, I don't think so. I hope that there is still a org.eclipse.tm4e.languageconfiguration.languageConfigurations extension for C/C++ content types and the mapping of tm4e C/C++ content types to cpp/language-configuration.json and the scopeNameContentTypeBinding in the org.eclipse.tm4e.registry.grammars extension for lng.cpp and lng.c content types is still present.

@ghentschke ghentschke force-pushed the clean-up-plugin branch 8 times, most recently from 06536d0 to 9419729 Compare March 13, 2023 11:06
@ghentschke
Remove doubled language configurations
90e35dc 
Since org.eclipse.tm4e.language_pack comes along with CDT the
org.eclipse.lsp plug-in does need to hold language configuration files
any more. There is one drawback: the language configuration definitions
e.g. autoClosingPairs does not work for C++ standard header files
without file extension.
ruspl-afed
ruspl-afed reviewed Apr 26, 2023
View reviewed changes
releng/org.eclipse.cdt.lsp.target/org.eclipse.cdt.lsp.target.target
<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
<repository location="https://download.eclipse.org/lsp4e/releases/0.20.5/" />
<repository location="http://download.eclipse.org/lsp4e/snapshots/" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider using https

releng/org.eclipse.cdt.lsp.target/org.eclipse.cdt.lsp.target.target Show resolved Hide resolved
@ruspl-afed
Copy link
Member

@ghentschke is it still relevant?

@ghentschke
Copy link
Contributor Author

ghentschke commented May 29, 2024 •
edited
Loading

@ghentschke is it still relevant?

I am not sure. I want to take a closer look at this PR when we have released cdt-lsp 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruspl-afed ruspl-afed ruspl-afed left review comments

@jonahgraham jonahgraham Awaiting requested review from jonahgraham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghentschke @jonahgraham @ruspl-afed