-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce 'Endianness' in UI and honor it during group rendering #93
Conversation
41ecf3a
to
9a93c61
Compare
@colin-grant-work Thank you for having a look at this so quickly! I just rebased the branch to resolve the merge conflict (no other changes). |
@martin-fleck-at, looks like we've managed to create new conflicts in the meantime, sorry! |
9a93c61
to
990be70
Compare
@colin-grant-work I small price to pay for all that progress we are making! ;-) I rebased the change on the latest master. |
- Move Endianness interface into common code - Add setting for 'Endianness' in package.json - Add option for 'Endianness' in options panel - Assume DAP as big endian and revert byte-order for little endian - Set 'Little Endian' as default as it may be more common Closes eclipse-cdt-cloud#88
990be70
to
df47e22
Compare
Just another rebase :-) |
@thegecko , @colin-grant-work , @planger , could one of you please merge before we catch another merge conflict. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hang on, something's broken with the autofit now, @martin-fleck-at :
It looks like it truncates now cells in the Data
column.
Widened Data
column, still truncated but a little less since more space
@jreineckearm @martin-fleck-at I will have a look at it. My approach to smooth the rendering creates more problems, and it is not worth those headaches. See #99 |
@jreineckearm Do you agree that this PR can then be merged since the issue will be fixed as part of #99? |
@martin-fleck-at , yes I agree ;-) |
What it does
Closes #88
How to test
Review checklist
Reminder for reviewers