Advanced Settings as popover

[arekzaluski]

What it does

Polish for the settings area : #27

Screenshots

How to test

• Run debug and open memory inspector window
• Select advanced settings button

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[arekzaluski]

@colin-grant-work Thank you for checking and very good comments. I've addressed them:

UI after changes:

[colin-grant-work]

A little bit more cleanup of the showRenderOptions state:

vscode-memory-inspector/src/webview/components/options-widget.tsx

Line 49 in 07c871c

this.state = { showRenderOptions: false };

vscode-memory-inspector/src/webview/components/options-widget.tsx

Line 35 in 07c871c

showRenderOptions: boolean;

[arekzaluski]

A little bit more cleanup of the showRenderOptions state:

vscode-memory-inspector/src/webview/components/options-widget.tsx

Line 49 in 07c871c

this.state = { showRenderOptions: false };

vscode-memory-inspector/src/webview/components/options-widget.tsx

Line 35 in 07c871c

showRenderOptions: boolean;

You are right. I've missed that it is no longer needed. I've just removed it.

[thegecko]

Thanks @arekzaluski

Are you happy to merge this @colin-grant-work ?