Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for display options #34

Merged
merged 14 commits into from
Sep 19, 2023
Merged

Add configuration for display options #34

merged 14 commits into from
Sep 19, 2023

Conversation

kenneth-marut-work
Copy link
Contributor

@kenneth-marut-work kenneth-marut-work commented Sep 5, 2023 •
edited
Loading

What it does

Addresses second bullet point in #27 by adding configuration options to persist column display and byte display preferences.

How to test

  • Get a running debug session going and open the memory inspector
  • open the preferences view and search "memory inspector"
  • toggle the new preferences for variables/ascii display as well as wordsPerGroup/groupsPerRow, observe that behave as expected
  • Relaunch the extension, observe that the extension starts up with your settings

Review checklist

Reminder for reviewers

@kenneth-marut-work kenneth-marut-work changed the title Draft: Add configuration for display options Add configuration for display options Sep 5, 2023
@kenneth-marut-work kenneth-marut-work requested review from colin-grant-work and thegecko and removed request for colin-grant-work September 5, 2023 21:25
@kenneth-marut-work kenneth-marut-work mentioned this pull request Sep 6, 2023
Merged
1 task
@kenneth-marut-work kenneth-marut-work changed the base branch from main to feature/paginate-memory September 6, 2023 22:05
@kenneth-marut-work kenneth-marut-work mentioned this pull request Sep 12, 2023
Closed
3 tasks
colin-grant-work
colin-grant-work reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@colin-grant-work colin-grant-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes to the preference format, but the functionality looks good to me 👍

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@kenneth-marut-work kenneth-marut-work changed the base branch from feature/paginate-memory to main September 19, 2023 17:31
@kenneth-marut-work
Copy link
Contributor Author

@colin-grant-work thanks for the review, I've pushed changes in response to your comments

@colin-grant-work colin-grant-work merged commit a7a357d into eclipse-cdt-cloud:main Sep 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-grant-work colin-grant-work colin-grant-work approved these changes

@thegecko thegecko Awaiting requested review from thegecko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add configuration for pagination behavior Bytes Per Row select menu doesn't appear to work properly
2 participants
@kenneth-marut-work @colin-grant-work