Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More memory select cursor -> pointer #146

Merged
merged 1 commit into from
Oct 14, 2024
Merged

More memory select cursor -> pointer #146

merged 1 commit into from
Oct 14, 2024

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Sep 20, 2024 •
edited
Loading

What it does

Fixes #144 by making the cursor for the select element a pointer.

How to test

  1. Open a memory inspector view and load memory.
  2. Move your cursor over the select element in the More Memory loading bar.
  3. Observe that it's a pointer.

Review checklist

Reminder for reviewers

jreineckearm
jreineckearm approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM!

@colin-grant-work colin-grant-work merged commit 70583f2 into eclipse-cdt-cloud:main Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreineckearm jreineckearm jreineckearm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX issues with More Memory loader
2 participants
@colin-grant-work @jreineckearm