Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid line break when editing a value while Auto Fit is enabled #132

Merged
merged 2 commits into from
May 8, 2024

Conversation

martin-fleck-at
Copy link
Contributor

What it does

  • Ensure that editing takes as much space as display
  • Use CSS to set styles on elements
  • Avoid large number of updates by guarding auto-fit group calculation

Fixes #112

How to test

  • Configure "Groups per Row" to "Autofit"
  • Narrow the Data column so that it just adds a new group on a row
  • Activate the in-place edit for a group
  • Should not cause a line break

Review checklist

Reminder for reviewers

@jreineckearm
Copy link
Contributor

Nice! I can see that the problematic behavior with the edit box is gone.
But unfortunately, I see now line breaks in corner cases without edit box which do not show with the main branch.

image

image

@martin-fleck-at , could you please have a look?

martin-fleck-at and others added 2 commits May 6, 2024 14:15
- Ensure that editing takes as much space as display
- Use CSS to set styles on elements
- Avoid large number of updates by guarding auto-fit group calculation

Fixes eclipse-cdt-cloud#112
@planger
Copy link
Contributor

planger commented May 6, 2024

@jreineckearm Thanks for noticing the issue! I've had a look and fixed the width calculation, which now didn't take the additional 1px padding left and right for the potential input field when editing into account. Can you please check if this also resolves the issue for you? Thank you!

Edit: Also I rebased to take in the recent merge of the CSS changes to make sure they don't have an impact.

Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for refining the fix, @planger ! The problem is indeed gone now.

@planger
Copy link
Contributor

planger commented May 8, 2024

Thank you for confirming @jreineckearm!
@colin-grant-work I think this isn't a critical change with some big impact, but wanted to put you in the loop before merging. Please let me know if you have any feedback or are ok with this change. Thank you!

@planger planger merged commit 1ec6ea9 into eclipse-cdt-cloud:main May 8, 2024
5 checks passed
@planger planger deleted the issues/112 branch May 8, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit memory value can cause "line break" in row for "autofit" groups per row
4 participants