Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit memory value can cause "line break" in row for "autofit" groups per row #112

Closed
jreineckearm opened this issue Mar 21, 2024 · 0 comments · Fixed by #132
Closed

Edit memory value can cause "line break" in row for "autofit" groups per row #112

jreineckearm opened this issue Mar 21, 2024 · 0 comments · Fixed by #132
Assignees
@martin-fleck-at
Labels
bug Something isn't working

Comments

@jreineckearm
Copy link
Contributor

Description

Editing a memory value renders an in-place edit box which is slightly wider than the normal display of a group.
This can lead to rendering line breaks if "groups per row" is set to "autofit" and the Data column is close to readjusting the effective number of groups per row.

How to reproduce:

Expected behavior

  • Expected behavior is that this does not cause a change of effective groups per row. The additional size of the in-place edit should be taken into account for calculating the edit box.

Environment

  • OS: Windows 10 Enterprise
  • Browser: N/A
  • Theia or VS Code Version: VS Code 1.87.2

Additional information
@jreineckearm jreineckearm added the bug Something isn't working label Mar 21, 2024
@jreineckearm jreineckearm mentioned this issue Mar 21, 2024
Merged
1 task
@planger planger assigned martin-fleck-at and unassigned tortmayr Apr 30, 2024
martin-fleck-at added a commit to eclipsesource/vscode-memory-inspector that referenced this issue Apr 30, 2024
@martin-fleck-at
Avoid line break when editing a value while Auto Fit is enabled
4d8eafd 
- Ensure that editing takes as much space as display
- Use CSS to set styles on elements
- Avoid large number of updates by guarding auto-fit group calculation

Fixes eclipse-cdt-cloud#112
@martin-fleck-at martin-fleck-at mentioned this issue Apr 30, 2024
Merged
1 task
planger pushed a commit to eclipsesource/vscode-memory-inspector that referenced this issue May 6, 2024
@martin-fleck-at @planger
Avoid line break when editing a value while Auto Fit is enabled
5c22d73 
- Ensure that editing takes as much space as display
- Use CSS to set styles on elements
- Avoid large number of updates by guarding auto-fit group calculation

Fixes eclipse-cdt-cloud#112
planger added a commit that referenced this issue May 8, 2024
@martin-fleck-at @planger
Avoid line break when editing a value while Auto Fit is enabled (#132)
1ec6ea9 
- Ensure that editing takes as much space as display
- Use CSS to set styles on elements
- Avoid large number of updates by guarding auto-fit group calculation

Fixes #112

Co-authored-by: Philip Langer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martin-fleck-at martin-fleck-at

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@tortmayr @martin-fleck-at @jreineckearm