Conditional 'Show In Memory Inspector' for Variable

Add new conditional for context menu showing Memory Inspector for a
variable because some DAPs may not support it.

Signed-off-by: Thor Thayer <[email protected]>

package.json

@@ -148,7 +148,7 @@
       "debug/variables/context": [
         {
           "command": "memory-inspector.show-variable",
-          "when": "canViewMemory && memory-inspector.canRead"
+          "when": "canViewMemory && memory-inspector.canReadVariable"
         },
         {
           "command": "memory-inspector.go-to-value",
@@ -162,7 +162,7 @@
       "view/item/context": [
         {
           "command": "memory-inspector.show-variable",
-          "when": "canViewMemory && memory-inspector.canRead"
+          "when": "canViewMemory && memory-inspector.canReadVariable"
         }
       ],
       "explorer/context": [

src/common/messaging.ts

@@ -48,6 +48,7 @@ export interface SessionContext {
     canRead: boolean;
     canWrite: boolean;
     stopped?: boolean;
+    canReadVariable: boolean;
 }
 
 // Notifications

src/plugin/adapter-registry/adapter-capabilities.ts

@@ -36,6 +36,7 @@ export interface AdapterCapabilities {
     writeMemory?(session: vscode.DebugSession, params: WriteMemoryArguments, context?: Context): Promise<WriteMemoryResult>;
     getContexts?(session: vscode.DebugSession): Promise<Context[]>;
     getCurrentContext?(session: vscode.DebugSession): Promise<Context | undefined>;
+    supportShowVariables?(session: vscode.DebugSession): boolean;
 }
 
 export type WithChildren<Original> = Original & { children?: Array<WithChildren<DebugProtocol.Variable>> };
@@ -143,6 +144,8 @@ export class AdapterVariableTracker implements vscode.DebugAdapterTracker {
 
     getContexts?(session: vscode.DebugSession): Promise<Context[]>;
     getCurrentContext?(session: vscode.DebugSession): Promise<Context | undefined>;
+
+    supportShowVariables?(session: vscode.DebugSession): boolean;
 }
 
 export class VariableTracker implements AdapterCapabilities {

src/plugin/adapter-registry/amalgamator-gdb-tracker.ts

@@ -57,6 +57,10 @@ export class AmalgamatorSessionManager extends VariableTracker implements Adapte
     async getCurrentContext(session: vscode.DebugSession): Promise<Context | undefined> {
         return this.sessions.get(session.id)?.getCurrentContext?.(session);
     }
+
+    supportShowVariables(_session: vscode.DebugSession): boolean {
+        return false;
+    }
 }
 
 export class AmalgamatorGdbVariableTransformer extends AdapterVariableTracker {

src/plugin/memory-provider.ts

@@ -111,4 +111,10 @@ export class MemoryProvider {
         const handler = this.adapterRegistry?.getHandlerForSession(session.type);
         return handler?.getCurrentContext?.(session);
     }
+
+    public supportShowVariables(): boolean {
+        const session = this.sessionTracker.assertActiveSession('supports show variables');
+        const handler = this.adapterRegistry?.getHandlerForSession(session.type);
+        return handler?.supportShowVariables?.(session) ?? true;
+    }
 }

src/plugin/memory-webview-main.ts

@@ -284,11 +284,14 @@ export class MemoryWebview implements vscode.CustomReadonlyEditorProvider {
 
     protected createContext(session = this.sessionTracker.activeSession): SessionContext {
         const sessionId = session?.id;
+        const canReadVariables = !!this.sessionTracker.hasDebugCapability(session, 'supportsReadMemoryRequest') &&
+                !!this.memoryProvider.supportShowVariables();
         return {
             sessionId,
             canRead: !!this.sessionTracker.hasDebugCapability(session, 'supportsReadMemoryRequest'),
             canWrite: !!this.sessionTracker.hasDebugCapability(session, 'supportsWriteMemoryRequest'),
-            stopped: this.sessionTracker.isStopped(session)
+            stopped: this.sessionTracker.isStopped(session),
+            canReadVariable: !!this.sessionTracker.hasDebugCapability(session, 'supportsReadMemoryRequest') && !!canReadVariables
         };
     }
 

src/webview/memory-webview-view.tsx

@@ -74,7 +74,8 @@ export interface MemoryAppState extends MemoryState, MemoryDisplayConfiguration
 
 export const DEFAULT_SESSION_CONTEXT: SessionContext = {
     canRead: false,
-    canWrite: false
+    canWrite: false,
+    canReadVariable: false
 };
 
 export const DEFAULT_MEMORY_DISPLAY_CONFIGURATION: MemoryDisplayConfiguration = {